@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Correct an issue where "dashboard.panel.edit" fatals in the API console
Summary:
Ref T13650. Currently, viewing the API console help page for this method fatals because it constructs a generic, untyped panel.
As a step toward improving this, generate a concrete panel type instead. This isn't the best possible fix, see T13650 for discussion.
Test Plan: Viewed "dashboard.panel.edit" API page, now saw a usable page.
Maniphest Tasks: T13650
Differential Revision: https://secure.phabricator.com/D21668
+11
+11
src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php
+11
src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php
···
71
71
return $panel;
72
72
}
73
73
74
+
protected function newEditableObjectForDocumentation() {
75
+
$panel = parent::newEditableObjectForDocumentation();
76
+
77
+
$text_type = id(new PhabricatorDashboardTextPanelType())
78
+
->getPanelTypeKey();
79
+
80
+
$panel->setPanelType($text_type);
81
+
82
+
return $panel;
83
+
}
84
+
74
85
protected function newObjectQuery() {
75
86
return new PhabricatorDashboardPanelQuery();
76
87
}