@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix issue with transcripts that do not have associated rules
Some effects are synthetic and do not directly result from rules.
Auditors: btrahan
+3
-1
+3
-1
src/applications/herald/storage/transcript/HeraldApplyTranscript.php
+3
-1
src/applications/herald/storage/transcript/HeraldApplyTranscript.php
···
16
16
17
17
$this->setAction($effect->getAction());
18
18
$this->setTarget($effect->getTarget());
19
-
$this->setRuleID($effect->getRule()->getID());
19
+
if ($effect->getRule()) {
20
+
$this->setRuleID($effect->getRule()->getID());
21
+
}
20
22
$this->setReason($effect->getReason());
21
23
$this->setApplied($applied);
22
24
$this->setAppliedReason($reason);