recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Expose Differential actions for "transaction.search" in a basic way

Summary:
See PHI725. Ref T13151. These actions are somewhat unusual and I considered different ways to represent them (make them look like "status" transactions; build multiple synthetic transactions) but ultimately landed on the simplest approach of just exposing them more or less as they exist internally.

I haven't included data for any of them. Most don't really have any data, but "accept" does. I'm holding off on providing more data until after T731, which may shake up the internal format.

Test Plan: Applied most of these transactions against a revision, queried for it with `transaction.search`, got distinguishable transactions out.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19509

epriestley a94528ee 11f1c139

+72 -1
+8
src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php
··· 86 86 $this->renderObject()); 87 87 } 88 88 89 + public function getTransactionTypeForConduit($xaction) { 90 + return 'abandon'; 91 + } 92 + 93 + public function getFieldValuesForConduit($object, $data) { 94 + return array(); 95 + } 96 + 89 97 }
+8
src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
··· 234 234 $this->renderObject()); 235 235 } 236 236 237 + public function getTransactionTypeForConduit($xaction) { 238 + return 'accept'; 239 + } 240 + 241 + public function getFieldValuesForConduit($object, $data) { 242 + return array(); 243 + } 244 + 237 245 }
-1
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
··· 154 154 ); 155 155 } 156 156 157 - 158 157 }
+8
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
··· 87 87 $this->renderObject()); 88 88 } 89 89 90 + public function getTransactionTypeForConduit($xaction) { 91 + return 'commandeer'; 92 + } 93 + 94 + public function getFieldValuesForConduit($object, $data) { 95 + return array(); 96 + } 97 + 90 98 }
+8
src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
··· 119 119 return (bool)$this->getMetadataValue('draft.demote'); 120 120 } 121 121 122 + public function getTransactionTypeForConduit($xaction) { 123 + return 'plan-changes'; 124 + } 125 + 126 + public function getFieldValuesForConduit($object, $data) { 127 + return array(); 128 + } 129 + 122 130 }
+8
src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php
··· 85 85 $this->renderObject()); 86 86 } 87 87 88 + public function getTransactionTypeForConduit($xaction) { 89 + return 'reclaim'; 90 + } 91 + 92 + public function getFieldValuesForConduit($object, $data) { 93 + return array(); 94 + } 95 + 88 96 }
+8
src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php
··· 99 99 $this->renderObject()); 100 100 } 101 101 102 + public function getTransactionTypeForConduit($xaction) { 103 + return 'request-changes'; 104 + } 105 + 106 + public function getFieldValuesForConduit($object, $data) { 107 + return array(); 108 + } 109 + 102 110 }
+8
src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php
··· 72 72 $this->renderObject()); 73 73 } 74 74 75 + public function getTransactionTypeForConduit($xaction) { 76 + return 'reopen'; 77 + } 78 + 79 + public function getFieldValuesForConduit($object, $data) { 80 + return array(); 81 + } 82 + 75 83 }
+8
src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
··· 84 84 $this->renderObject()); 85 85 } 86 86 87 + public function getTransactionTypeForConduit($xaction) { 88 + return 'request-review'; 89 + } 90 + 91 + public function getFieldValuesForConduit($object, $data) { 92 + return array(); 93 + } 94 + 87 95 }
+8
src/applications/differential/xaction/DifferentialRevisionResignTransaction.php
··· 93 93 $this->renderObject()); 94 94 } 95 95 96 + public function getTransactionTypeForConduit($xaction) { 97 + return 'resign'; 98 + } 99 + 100 + public function getFieldValuesForConduit($object, $data) { 101 + return array(); 102 + } 103 + 96 104 }