recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix Mercurial commit history ordering

Summary:
See <https://discourse.phabricator-community.org/t/diffusion-observed-mercurial-repository-history-broken/825>.

In D18769, I rewrote this from using the `--branch` flag (which is unsafe and does not function on branches named `--config=x.y` and such).

However, this rewrite accidentally changed the result order, which impacted Mercurial commit hisotry lists and graphs. Swap the order of the constraints so we get newest-to-oldest again, as expected.

Test Plan: Viewed a Mercurial repository's history graph, saw sensible chronology after the patch.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18817

epriestley a989dd18 46d496b8

+1 -1
+1 -1
src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
··· 130 130 } else { 131 131 $path_arg = ''; 132 132 $revset_arg = hgsprintf( 133 - 'branch(%s) and reverse(ancestors(%s))', 133 + 'reverse(ancestors(%s)) and branch(%s)', 134 134 $drequest->getBranch(), 135 135 $commit_hash); 136 136 }