recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Support bulk edit of "points" for Maniphest tasks

Summary: Ref T13025. Fixes T10973. Fairly straightforward. The "points" type is just an alias for "text" today.

Test Plan: Bulk edited points.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13025, T10973

Differential Revision: https://secure.phabricator.com/D18889

epriestley a9d7b4f0 d9b6513a

+18
+2
src/__phutil_library_map__.php
··· 223 223 'AuditQueryConduitAPIMethod' => 'applications/audit/conduit/AuditQueryConduitAPIMethod.php', 224 224 'AuthManageProvidersCapability' => 'applications/auth/capability/AuthManageProvidersCapability.php', 225 225 'BulkParameterType' => 'applications/transactions/bulk/type/BulkParameterType.php', 226 + 'BulkPointsParameterType' => 'applications/transactions/bulk/type/BulkPointsParameterType.php', 226 227 'BulkRemarkupParameterType' => 'applications/transactions/bulk/type/BulkRemarkupParameterType.php', 227 228 'BulkSelectParameterType' => 'applications/transactions/bulk/type/BulkSelectParameterType.php', 228 229 'BulkStringParameterType' => 'applications/transactions/bulk/type/BulkStringParameterType.php', ··· 5252 5253 'AuditQueryConduitAPIMethod' => 'AuditConduitAPIMethod', 5253 5254 'AuthManageProvidersCapability' => 'PhabricatorPolicyCapability', 5254 5255 'BulkParameterType' => 'Phobject', 5256 + 'BulkPointsParameterType' => 'BulkParameterType', 5255 5257 'BulkRemarkupParameterType' => 'BulkParameterType', 5256 5258 'BulkSelectParameterType' => 'BulkParameterType', 5257 5259 'BulkStringParameterType' => 'BulkParameterType',
+1
src/applications/maniphest/editor/ManiphestEditEngine.php
··· 234 234 $fields[] = id(new PhabricatorPointsEditField()) 235 235 ->setKey('points') 236 236 ->setLabel($points_label) 237 + ->setBulkEditLabel($action_label) 237 238 ->setDescription(pht('Point value of the task.')) 238 239 ->setConduitDescription(pht('Change the task point value.')) 239 240 ->setConduitTypeDescription(pht('New task point value.'))
+10
src/applications/transactions/bulk/type/BulkPointsParameterType.php
··· 1 + <?php 2 + 3 + final class BulkPointsParameterType 4 + extends BulkParameterType { 5 + 6 + public function getPHUIXControlType() { 7 + return 'points'; 8 + } 9 + 10 + }
+5
src/applications/transactions/editfield/PhabricatorPointsEditField.php
··· 14 14 protected function newCommentAction() { 15 15 return id(new PhabricatorEditEnginePointsCommentAction()); 16 16 } 17 + 18 + protected function newBulkParameterType() { 19 + return new BulkPointsParameterType(); 20 + } 21 + 17 22 }