recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Mark the "Reviewer" field for Commits as deprecated

Summary:
Depends on D18931. Ref T13048. Ref T13041. This field means "the first accepting reviewer, where order is mostly arbitrary". Modern rules should almost certainly use "Accepting Reviewers" instead.

Getting rid of this completely is a pain, but we can at least reduce confusion by marking it as not-the-new-hotness. Add a "Deprecated" group, move it there, and mark it for exile.

Test Plan:
Edited a commit rule, saw it in "Deprecated" group at the bottom of the list:

{F5395001}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13048, T13041

Differential Revision: https://secure.phabricator.com/D18932

epriestley a9f87857 5c762d89

+22 -1
+2
src/__phutil_library_map__.php
··· 1362 1362 'HeraldController' => 'applications/herald/controller/HeraldController.php', 1363 1363 'HeraldCoreStateReasons' => 'applications/herald/state/HeraldCoreStateReasons.php', 1364 1364 'HeraldDAO' => 'applications/herald/storage/HeraldDAO.php', 1365 + 'HeraldDeprecatedFieldGroup' => 'applications/herald/field/HeraldDeprecatedFieldGroup.php', 1365 1366 'HeraldDifferentialAdapter' => 'applications/differential/herald/HeraldDifferentialAdapter.php', 1366 1367 'HeraldDifferentialDiffAdapter' => 'applications/differential/herald/HeraldDifferentialDiffAdapter.php', 1367 1368 'HeraldDifferentialRevisionAdapter' => 'applications/differential/herald/HeraldDifferentialRevisionAdapter.php', ··· 6561 6562 'HeraldController' => 'PhabricatorController', 6562 6563 'HeraldCoreStateReasons' => 'HeraldStateReasons', 6563 6564 'HeraldDAO' => 'PhabricatorLiskDAO', 6565 + 'HeraldDeprecatedFieldGroup' => 'HeraldFieldGroup', 6564 6566 'HeraldDifferentialAdapter' => 'HeraldAdapter', 6565 6567 'HeraldDifferentialDiffAdapter' => 'HeraldDifferentialAdapter', 6566 6568 'HeraldDifferentialRevisionAdapter' => array(
+5 -1
src/applications/diffusion/herald/DiffusionCommitReviewerHeraldField.php
··· 6 6 const FIELDCONST = 'diffusion.commit.reviewer'; 7 7 8 8 public function getHeraldFieldName() { 9 - return pht('Reviewer'); 9 + return pht('Reviewer (Deprecated)'); 10 + } 11 + 12 + public function getFieldGroupKey() { 13 + return HeraldDeprecatedFieldGroup::FIELDGROUPKEY; 10 14 } 11 15 12 16 public function getHeraldFieldValue($object) {
+15
src/applications/herald/field/HeraldDeprecatedFieldGroup.php
··· 1 + <?php 2 + 3 + final class HeraldDeprecatedFieldGroup extends HeraldFieldGroup { 4 + 5 + const FIELDGROUPKEY = 'deprecated'; 6 + 7 + public function getGroupLabel() { 8 + return pht('Deprecated'); 9 + } 10 + 11 + protected function getGroupOrder() { 12 + return 99999; 13 + } 14 + 15 + }