@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
After toggling DarkConsole, force a user settings cache fill
Summary:
Ref T10078. Currently, you toggle DarkConsole and then load a page, but on the load we have to refill your settings cache since toggling DarkConsole dirtied it.
This is fine, except that it makes it harder to understand what's going on with queries on a page. Just force it to reload right away instead.
Test Plan: Toggled DarkConsole, reloaded page, no longer saw settings toggle-related cache fill.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10078
Differential Revision: https://secure.phabricator.com/D16044
+11
+11
src/applications/console/controller/DarkConsoleController.php
+11
src/applications/console/controller/DarkConsoleController.php
···
59
59
$xactions = array();
60
60
$xactions[] = $preferences->newTransaction($key, $value);
61
61
$editor->applyTransactions($preferences, $xactions);
62
+
63
+
// Reload the user to regenerate their preferences cache. If we don't
64
+
// do this, the "Services" tab gets misleadingly spammed up with cache
65
+
// fills that are only filling because you toggled the console or switched
66
+
// tabs. This makes it harder to see what's really going on, so just force
67
+
// a cache regeneration here.
68
+
id(new PhabricatorPeopleQuery())
69
+
->setViewer($viewer)
70
+
->withPHIDs(array($viewer->getPHID()))
71
+
->needUserSettings(true)
72
+
->execute();
62
73
}
63
74
64
75
}