@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make clicking on file icon in lightbox download file
Summary: Ref T3612, this adds a anchor around the large icon with hover state so you can download from here as well.
Test Plan: Hover over .ics file, click, get download.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T3612
Differential Revision: https://secure.phabricator.com/D16977
+27
-17
+15
-15
resources/celerity/map.php
+15
-15
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => '0b64e988',
11
11
'conpherence.pkg.js' => '6249a1cf',
12
-
'core.pkg.css' => '5b1fcbf1',
13
-
'core.pkg.js' => '795a0f8b',
12
+
'core.pkg.css' => '27fd330b',
13
+
'core.pkg.js' => '14fcb9e4',
14
14
'darkconsole.pkg.js' => 'e7393ebb',
15
15
'differential.pkg.css' => 'a4ba74b5',
16
16
'differential.pkg.js' => '634399e9',
···
151
151
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
152
152
'rsrc/css/phui/phui-info-view.css' => 'ec92802a',
153
153
'rsrc/css/phui/phui-invisible-character-view.css' => '6993d9f0',
154
-
'rsrc/css/phui/phui-lightbox.css' => '9d65cfb5',
154
+
'rsrc/css/phui/phui-lightbox.css' => '0a035e40',
155
155
'rsrc/css/phui/phui-list.css' => '9da2aa00',
156
156
'rsrc/css/phui/phui-object-box.css' => '6b487c57',
157
157
'rsrc/css/phui/phui-object-item-list-view.css' => '87278fa0',
···
505
505
'rsrc/js/core/behavior-hovercard.js' => 'bcaccd64',
506
506
'rsrc/js/core/behavior-keyboard-pager.js' => 'a8da01f0',
507
507
'rsrc/js/core/behavior-keyboard-shortcuts.js' => '01fca1f0',
508
-
'rsrc/js/core/behavior-lightbox-attachments.js' => 'c0a04fd9',
508
+
'rsrc/js/core/behavior-lightbox-attachments.js' => 'e089b29b',
509
509
'rsrc/js/core/behavior-line-linker.js' => '1499a8cb',
510
510
'rsrc/js/core/behavior-more.js' => 'a80d0378',
511
511
'rsrc/js/core/behavior-object-selector.js' => 'e0ec7f2f',
···
651
651
'javelin-behavior-history-install' => '7ee2b591',
652
652
'javelin-behavior-icon-composer' => '8499b6ab',
653
653
'javelin-behavior-launch-icon-composer' => '48086888',
654
-
'javelin-behavior-lightbox-attachments' => 'c0a04fd9',
654
+
'javelin-behavior-lightbox-attachments' => 'e089b29b',
655
655
'javelin-behavior-line-chart' => 'e4232876',
656
656
'javelin-behavior-load-blame' => '42126667',
657
657
'javelin-behavior-maniphest-batch-editor' => '782ab6e7',
···
869
869
'phui-info-view-css' => 'ec92802a',
870
870
'phui-inline-comment-view-css' => '5953c28e',
871
871
'phui-invisible-character-view-css' => '6993d9f0',
872
-
'phui-lightbox-css' => '9d65cfb5',
872
+
'phui-lightbox-css' => '0a035e40',
873
873
'phui-list-view-css' => '9da2aa00',
874
874
'phui-object-box-css' => '6b487c57',
875
875
'phui-object-item-list-view-css' => '87278fa0',
···
1946
1946
'javelin-install',
1947
1947
'javelin-dom',
1948
1948
),
1949
-
'c0a04fd9' => array(
1950
-
'javelin-behavior',
1951
-
'javelin-stratcom',
1952
-
'javelin-dom',
1953
-
'javelin-mask',
1954
-
'javelin-util',
1955
-
'phuix-icon-view',
1956
-
'phabricator-busy',
1957
-
),
1958
1949
'c40ce0ea' => array(
1959
1950
'phui-timeline-view-css',
1960
1951
),
···
2065
2056
'javelin-typeahead',
2066
2057
'javelin-typeahead-ondemand-source',
2067
2058
'javelin-dom',
2059
+
),
2060
+
'e089b29b' => array(
2061
+
'javelin-behavior',
2062
+
'javelin-stratcom',
2063
+
'javelin-dom',
2064
+
'javelin-mask',
2065
+
'javelin-util',
2066
+
'phuix-icon-view',
2067
+
'phabricator-busy',
2068
2068
),
2069
2069
'e0ec7f2f' => array(
2070
2070
'javelin-behavior',
+1
src/view/page/PhabricatorStandardPageView.php
+1
src/view/page/PhabricatorStandardPageView.php
+7
webroot/rsrc/css/phui/phui-lightbox.css
+7
webroot/rsrc/css/phui/phui-lightbox.css
···
55
55
display: block;
56
56
height: 120px;
57
57
width: 320px;
58
+
color: {$darkbluetext};
59
+
}
60
+
61
+
.lightbox-attachment .lightbox-icon-frame:hover,
62
+
.lightbox-attachment .lightbox-icon-frame:hover .phui-icon-view {
63
+
color: {$anchor};
64
+
text-decoration: none;
58
65
}
59
66
60
67
.lightbox-attachment.comment-panel-open .lightbox-icon-frame {
+4
-2
webroot/rsrc/js/core/behavior-lightbox-attachments.js
+4
-2
webroot/rsrc/js/core/behavior-lightbox-attachments.js
···
109
109
target_data.name
110
110
);
111
111
img =
112
-
JX.$N('div',
112
+
JX.$N('a',
113
113
{
114
114
className : 'lightbox-icon-frame',
115
+
sigil : 'lightbox-download-submit',
116
+
href : '#',
115
117
},
116
118
[ imgIcon, nameElement ]
117
119
);
···
362
364
363
365
var _startDownload = function(e) {
364
366
e.kill();
365
-
var form = e.getNode('tag:form');
367
+
var form = JX.$('lightbox-download-form');
366
368
form.submit();
367
369
};
368
370