@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove legacy numeric Audit status constants
Summary: Depends on D19655. Ref T13197. These no longer have callers.
Test Plan: Grepped for these constants.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13197
Differential Revision: https://secure.phabricator.com/D19656
+6
-13
+6
-13
src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
+6
-13
src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
···
5
5
private $key;
6
6
private $spec = array();
7
7
8
-
const NONE = 0;
9
-
const NEEDS_AUDIT = 1;
10
-
const CONCERN_RAISED = 2;
11
-
const PARTIALLY_AUDITED = 3;
12
-
const FULLY_AUDITED = 4;
13
-
const NEEDS_VERIFICATION = 5;
14
-
15
8
const MODERN_NONE = 'none';
16
9
const MODERN_NEEDS_AUDIT = 'needs-audit';
17
10
const MODERN_CONCERN_RAISED = 'concern-raised';
···
125
118
return array(
126
119
self::MODERN_NONE => array(
127
120
'name' => pht('No Audits'),
128
-
'legacy' => self::NONE,
121
+
'legacy' => 0,
129
122
'icon' => 'fa-check',
130
123
'color' => 'bluegrey',
131
124
'closed' => true,
132
125
),
133
126
self::MODERN_NEEDS_AUDIT => array(
134
127
'name' => pht('Audit Required'),
135
-
'legacy' => self::NEEDS_AUDIT,
128
+
'legacy' => 1,
136
129
'icon' => 'fa-exclamation-circle',
137
130
'color' => 'orange',
138
131
'closed' => false,
139
132
),
140
133
self::MODERN_CONCERN_RAISED => array(
141
134
'name' => pht('Concern Raised'),
142
-
'legacy' => self::CONCERN_RAISED,
135
+
'legacy' => 2,
143
136
'icon' => 'fa-times-circle',
144
137
'color' => 'red',
145
138
'closed' => false,
146
139
),
147
140
self::MODERN_PARTIALLY_AUDITED => array(
148
141
'name' => pht('Partially Audited'),
149
-
'legacy' => self::PARTIALLY_AUDITED,
142
+
'legacy' => 3,
150
143
'icon' => 'fa-check-circle-o',
151
144
'color' => 'yellow',
152
145
'closed' => false,
153
146
),
154
147
self::MODERN_AUDITED => array(
155
148
'name' => pht('Audited'),
156
-
'legacy' => self::FULLY_AUDITED,
149
+
'legacy' => 4,
157
150
'icon' => 'fa-check-circle',
158
151
'color' => 'green',
159
152
'closed' => true,
160
153
),
161
154
self::MODERN_NEEDS_VERIFICATION => array(
162
155
'name' => pht('Needs Verification'),
163
-
'legacy' => self::NEEDS_VERIFICATION,
156
+
'legacy' => 5,
164
157
'icon' => 'fa-refresh',
165
158
'color' => 'indigo',
166
159
'closed' => false,