@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix incorrect return value of PhabricatorCustomField::readValueFromObject()
Summary:
`PhabricatorCustomField::readValueFromObject()` returns `$this` while none of its seven child class implementations returns any value.
Make the method return nothing to make PHPStan a bit happier.
Closes T15895
Test Plan: Run static code analysis; read/grep the codebase.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15895
Differential Revision: https://we.phorge.it/D25751
+1
-2
+1
-2
src/infrastructure/customfield/field/PhabricatorCustomField.php
+1
-2
src/infrastructure/customfield/field/PhabricatorCustomField.php
···
443
443
*
444
444
* @param PhabricatorCustomFieldInterface $object The object this field
445
445
* belongs to.
446
-
* @return $this
447
446
* @task context
448
447
*/
449
448
public function readValueFromObject(PhabricatorCustomFieldInterface $object) {
450
449
if ($this->proxy) {
451
450
$this->proxy->readValueFromObject($object);
452
451
}
453
-
return $this;
452
+
return;
454
453
}
455
454
456
455