recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove very old "owners-default-path" code from Owners

Summary: Ref T12590. This is ancient code which was used to prefill `/trunk/tfb/www/` or similar at Facebook. I don't think it ever had a UI and no install has asked for this feature since 2011.

Test Plan: Grepped for affected symbols, edited paths in Owners.

Maniphest Tasks: T12590

Differential Revision: https://secure.phabricator.com/D19189

epriestley ab0ac7f6 229d4677

+23 -42
+20 -20
resources/celerity/map.php
··· 418 418 'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888', 419 419 'rsrc/js/application/harbormaster/behavior-harbormaster-log.js' => '191b4909', 420 420 'rsrc/js/application/herald/HeraldRuleEditor.js' => 'dca75c0e', 421 - 'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec', 421 + 'rsrc/js/application/herald/PathTypeahead.js' => '78039abe', 422 422 'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3', 423 423 'rsrc/js/application/maniphest/behavior-batch-selector.js' => 'ad54037e', 424 424 'rsrc/js/application/maniphest/behavior-line-chart.js' => 'e4232876', 425 425 'rsrc/js/application/maniphest/behavior-list-edit.js' => 'a9f88de2', 426 426 'rsrc/js/application/maniphest/behavior-subpriorityeditor.js' => '71237763', 427 - 'rsrc/js/application/owners/OwnersPathEditor.js' => '996d62b9', 427 + 'rsrc/js/application/owners/OwnersPathEditor.js' => '52b9cbc4', 428 428 'rsrc/js/application/owners/owners-path-editor.js' => '7a68dda3', 429 429 'rsrc/js/application/passphrase/passphrase-credential-control.js' => '3cb0b2fc', 430 430 'rsrc/js/application/pholio/behavior-pholio-mock-edit.js' => 'bee502c8', ··· 764 764 'maniphest-task-edit-css' => 'fda62a9b', 765 765 'maniphest-task-summary-css' => '11cc5344', 766 766 'multirow-row-manager' => 'b5d57730', 767 - 'owners-path-editor' => '996d62b9', 767 + 'owners-path-editor' => '52b9cbc4', 768 768 'owners-path-editor-css' => '2f00933b', 769 769 'paste-css' => '9fcc9773', 770 - 'path-typeahead' => 'f7fc67ec', 770 + 'path-typeahead' => '78039abe', 771 771 'people-picture-menu-item-css' => 'a06f7f34', 772 772 'people-profile-css' => '4df76faf', 773 773 'phabricator-action-list-view-css' => '0bcd9a45', ··· 1337 1337 'javelin-vector', 1338 1338 'javelin-typeahead-static-source', 1339 1339 ), 1340 + '52b9cbc4' => array( 1341 + 'multirow-row-manager', 1342 + 'javelin-install', 1343 + 'path-typeahead', 1344 + 'javelin-dom', 1345 + 'javelin-util', 1346 + 'phabricator-prefab', 1347 + ), 1340 1348 '54b612ba' => array( 1341 1349 'javelin-color', 1342 1350 'javelin-install', ··· 1534 1542 'javelin-request', 1535 1543 'javelin-util', 1536 1544 ), 1545 + '78039abe' => array( 1546 + 'javelin-install', 1547 + 'javelin-typeahead', 1548 + 'javelin-dom', 1549 + 'javelin-request', 1550 + 'javelin-typeahead-ondemand-source', 1551 + 'javelin-util', 1552 + ), 1537 1553 '7927a7d3' => array( 1538 1554 'javelin-behavior', 1539 1555 'javelin-quicksand', ··· 1684 1700 'javelin-uri', 1685 1701 'javelin-mask', 1686 1702 'phabricator-drag-and-drop-file-upload', 1687 - ), 1688 - '996d62b9' => array( 1689 - 'multirow-row-manager', 1690 - 'javelin-install', 1691 - 'path-typeahead', 1692 - 'javelin-dom', 1693 - 'javelin-util', 1694 - 'phabricator-prefab', 1695 1703 ), 1696 1704 '9a6dd75c' => array( 1697 1705 'javelin-behavior', ··· 2162 2170 'javelin-reactornode', 2163 2171 'javelin-util', 2164 2172 'javelin-reactor', 2165 - ), 2166 - 'f7fc67ec' => array( 2167 - 'javelin-install', 2168 - 'javelin-typeahead', 2169 - 'javelin-dom', 2170 - 'javelin-request', 2171 - 'javelin-typeahead-ondemand-source', 2172 - 'javelin-util', 2173 2173 ), 2174 2174 'f829edb3' => array( 2175 2175 'javelin-view',
-11
src/applications/owners/controller/PhabricatorOwnersPathsController.php
··· 74 74 ->setViewer($viewer) 75 75 ->execute(); 76 76 77 - $default_paths = array(); 78 - foreach ($repos as $repo) { 79 - $default_path = $repo->getDetail('default-owners-path'); 80 - if ($default_path) { 81 - $default_paths[$repo->getPHID()] = $default_path; 82 - } 83 - } 84 - 85 - 86 77 $repo_map = array(); 87 78 foreach ($repos as $key => $repo) { 88 79 $monogram = $repo->getMonogram(); ··· 106 97 107 98 'completeURI' => '/diffusion/services/path/complete/', 108 99 'validateURI' => '/diffusion/services/path/validate/', 109 - 110 - 'repositoryDefaultPaths' => $default_paths, 111 100 )); 112 101 113 102 require_celerity_resource('owners-path-editor-css');
+1 -6
webroot/rsrc/js/application/herald/PathTypeahead.js
··· 17 17 this._completeURI = config.completeURI; 18 18 this._validateURI = config.validateURI; 19 19 this._errorDisplay = config.error_display; 20 - 21 - /* 22 - * Default values to preload the typeahead with, for extremely common 23 - * cases. 24 - */ 25 - this._textInputValues = config.repositoryDefaultPaths; 20 + this._textInputValues = {}; 26 21 27 22 this._initializeDatasource(); 28 23 this._initializeTypeahead(this._input);
+2 -5
webroot/rsrc/js/application/owners/OwnersPathEditor.js
··· 28 28 29 29 this._completeURI = config.completeURI; 30 30 this._validateURI = config.validateURI; 31 - this._repositoryDefaultPaths = config.repositoryDefaultPaths; 32 31 33 32 this._initializePaths(config.pathRefs); 34 33 }, ··· 66 65 * default for future rows. 67 66 */ 68 67 _lastRepositoryChoice : null, 69 - 70 - _repositoryDefaultPaths : null, 71 68 72 69 /* 73 70 * Initialize with 0 or more rows. ··· 144 141 [exclude_cell, repo_cell, typeahead_cell, error_display_cell]); 145 142 146 143 new JX.PathTypeahead({ 147 - repositoryDefaultPaths : this._repositoryDefaultPaths, 148 144 repo_select : repo_select, 149 145 path_input : path_input, 150 146 hardpoint : hardpoint, 151 147 error_display : error_display, 152 148 completeURI : this._completeURI, 153 - validateURI : this._validateURI}).start(); 149 + validateURI : this._validateURI 150 + }).start(); 154 151 155 152 this._count++; 156 153 return row;