@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with the Spaces EditField not reading values properly
Summary: Fixes T9988. This logic got inverted by accident at some point.
Test Plan:
- Edited a task, shifting spaces.
- Created a task in default space.
- Created a task in custom space.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9988
Differential Revision: https://secure.phabricator.com/D14787
+1
-1
+1
-1
src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php
+1
-1
src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php
···
91
91
->setValue($object->getPolicy($capability));
92
92
$fields[] = $policy_field;
93
93
94
-
if (!($object instanceof PhabricatorSpacesInterface)) {
94
+
if ($object instanceof PhabricatorSpacesInterface) {
95
95
if ($capability == PhabricatorPolicyCapability::CAN_VIEW) {
96
96
$type_space = PhabricatorTransactions::TYPE_SPACE;
97
97
if (isset($types[$type_space])) {