@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Really fix movable panels inside tab panels by changing the JX.Request serializer
Summary:
Depends on D20475. Ref T13272. Currently, if you `JX.Request` with `data` like `{x: null}`, we submit that as `?x=null`, i.e. as though `null` was the string `"null"`.
This is weird and almost certainly never intended/desiarable. In particular, it causes a bug where panels embedded inside tab panels are incorrectly draggable.
It's possible this breaks something which relied on the buggy behavior, but that seems unlikely.
Test Plan: Tried to drag a panel inside a tab panel, it really truly didn't work.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13272
Differential Revision: https://secure.phabricator.com/D20476
+18
-13
+13
-13
resources/celerity/map.php
+13
-13
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => '3c8a0668',
11
11
'conpherence.pkg.js' => '020aebcf',
12
12
'core.pkg.css' => '3dc188c0',
13
-
'core.pkg.js' => '9ac8af68',
13
+
'core.pkg.js' => 'ee320ca2',
14
14
'differential.pkg.css' => '8d8360fb',
15
15
'differential.pkg.js' => '67e02996',
16
16
'diffusion.pkg.css' => '42c75c37',
···
244
244
'rsrc/externals/javelin/lib/Leader.js' => '0d2490ce',
245
245
'rsrc/externals/javelin/lib/Mask.js' => '7c4d8998',
246
246
'rsrc/externals/javelin/lib/Quicksand.js' => 'd3799cb4',
247
-
'rsrc/externals/javelin/lib/Request.js' => '91863989',
247
+
'rsrc/externals/javelin/lib/Request.js' => '84e6891f',
248
248
'rsrc/externals/javelin/lib/Resource.js' => '740956e1',
249
249
'rsrc/externals/javelin/lib/Routable.js' => '6a18c42e',
250
250
'rsrc/externals/javelin/lib/Router.js' => '32755edb',
···
717
717
'javelin-reactor-dom' => '6cfa0008',
718
718
'javelin-reactor-node-calmer' => '225bbb98',
719
719
'javelin-reactornode' => '72960bc1',
720
-
'javelin-request' => '91863989',
720
+
'javelin-request' => '84e6891f',
721
721
'javelin-resource' => '740956e1',
722
722
'javelin-routable' => '6a18c42e',
723
723
'javelin-router' => '32755edb',
···
1595
1595
'javelin-dom',
1596
1596
'javelin-vector',
1597
1597
),
1598
+
'84e6891f' => array(
1599
+
'javelin-install',
1600
+
'javelin-stratcom',
1601
+
'javelin-util',
1602
+
'javelin-behavior',
1603
+
'javelin-json',
1604
+
'javelin-dom',
1605
+
'javelin-resource',
1606
+
'javelin-routable',
1607
+
),
1598
1608
'87428eb2' => array(
1599
1609
'javelin-behavior',
1600
1610
'javelin-diffusion-locate-file-source',
···
1650
1660
'javelin-util',
1651
1661
'javelin-workflow',
1652
1662
'javelin-stratcom',
1653
-
),
1654
-
91863989 => array(
1655
-
'javelin-install',
1656
-
'javelin-stratcom',
1657
-
'javelin-util',
1658
-
'javelin-behavior',
1659
-
'javelin-json',
1660
-
'javelin-dom',
1661
-
'javelin-resource',
1662
-
'javelin-routable',
1663
1663
),
1664
1664
'91befbcc' => array(
1665
1665
'javelin-behavior',
+5
webroot/rsrc/externals/javelin/lib/Request.js
+5
webroot/rsrc/externals/javelin/lib/Request.js
···
393
393
var uri = [];
394
394
for (var ii = 0; ii < list_of_pairs.length; ii++) {
395
395
var pair = list_of_pairs[ii];
396
+
397
+
if (pair[1] === null) {
398
+
continue;
399
+
}
400
+
396
401
var name = encodeURIComponent(pair[0]);
397
402
var value = encodeURIComponent(pair[1]);
398
403
uri.push(name + '=' + value);