@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove shouldShowSubscribersProperty() from SubscribableInterface

Summary:
Every caller returns `true`. This was added a long time ago for Projects, but projects are no longer subscribable.

I don't anticipate needing this in the future.

Test Plan: Grepped for this method.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15409

-107
-4
src/applications/badges/storage/PhabricatorBadgesBadge.php
··· 181 181 return ($this->creatorPHID == $phid); 182 182 } 183 183 184 - public function shouldShowSubscribersProperty() { 185 - return true; 186 - } 187 - 188 184 189 185 /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ 190 186
-4
src/applications/calendar/storage/PhabricatorCalendarEvent.php
··· 531 531 return ($phid == $this->getUserPHID()); 532 532 } 533 533 534 - public function shouldShowSubscribersProperty() { 535 - return true; 536 - } 537 - 538 534 /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ 539 535 540 536
-3
src/applications/countdown/storage/PhabricatorCountdown.php
··· 70 70 return ($phid == $this->getAuthorPHID()); 71 71 } 72 72 73 - public function shouldShowSubscribersProperty() { 74 - return true; 75 - } 76 73 77 74 /* -( PhabricatorApplicationTransactionInterface )------------------------- */ 78 75
-4
src/applications/differential/storage/DifferentialRevision.php
··· 485 485 return false; 486 486 } 487 487 488 - public function shouldShowSubscribersProperty() { 489 - return true; 490 - } 491 - 492 488 493 489 /* -( PhabricatorCustomFieldInterface )------------------------------------ */ 494 490
-4
src/applications/files/storage/PhabricatorFile.php
··· 1348 1348 return ($this->authorPHID == $phid); 1349 1349 } 1350 1350 1351 - public function shouldShowSubscribersProperty() { 1352 - return true; 1353 - } 1354 - 1355 1351 1356 1352 /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ 1357 1353
-4
src/applications/fund/storage/FundInitiative.php
··· 178 178 return ($phid == $this->getOwnerPHID()); 179 179 } 180 180 181 - public function shouldShowSubscribersProperty() { 182 - return true; 183 - } 184 - 185 181 186 182 /* -( PhabricatorTokenRecevierInterface )---------------------------------- */ 187 183
-4
src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php
··· 127 127 return false; 128 128 } 129 129 130 - public function shouldShowSubscribersProperty() { 131 - return true; 132 - } 133 - 134 130 135 131 /* -( PhabricatorApplicationTransactionInterface )------------------------- */ 136 132
-4
src/applications/herald/storage/HeraldRule.php
··· 328 328 return $this->isPersonalRule() && $phid == $this->getAuthorPHID(); 329 329 } 330 330 331 - public function shouldShowSubscribersProperty() { 332 - return true; 333 - } 334 - 335 331 336 332 /* -( PhabricatorDestructibleInterface )----------------------------------- */ 337 333
-4
src/applications/legalpad/storage/LegalpadDocument.php
··· 163 163 return ($this->creatorPHID == $phid); 164 164 } 165 165 166 - public function shouldShowSubscribersProperty() { 167 - return true; 168 - } 169 - 170 166 171 167 /* -( PhabricatorPolicyInterface )----------------------------------------- */ 172 168
-4
src/applications/macro/storage/PhabricatorFileImageMacro.php
··· 111 111 return false; 112 112 } 113 113 114 - public function shouldShowSubscribersProperty() { 115 - return true; 116 - } 117 - 118 114 119 115 /* -( PhabricatorTokenRecevierInterface )---------------------------------- */ 120 116
-4
src/applications/maniphest/storage/ManiphestTask.php
··· 269 269 return ($phid == $this->getOwnerPHID()); 270 270 } 271 271 272 - public function shouldShowSubscribersProperty() { 273 - return true; 274 - } 275 - 276 272 277 273 /* -( Markup Interface )--------------------------------------------------- */ 278 274
-4
src/applications/passphrase/storage/PassphraseCredential.php
··· 157 157 return false; 158 158 } 159 159 160 - public function shouldShowSubscribersProperty() { 161 - return true; 162 - } 163 - 164 160 165 161 /* -( PhabricatorDestructibleInterface )----------------------------------- */ 166 162
-4
src/applications/paste/storage/PhabricatorPaste.php
··· 155 155 return ($this->authorPHID == $phid); 156 156 } 157 157 158 - public function shouldShowSubscribersProperty() { 159 - return true; 160 - } 161 - 162 158 163 159 /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ 164 160
-4
src/applications/phame/storage/PhameBlog.php
··· 336 336 return ($this->creatorPHID == $phid); 337 337 } 338 338 339 - public function shouldShowSubscribersProperty() { 340 - return true; 341 - } 342 - 343 339 344 340 /* -( PhabricatorConduitResultInterface )---------------------------------- */ 345 341
-4
src/applications/phame/storage/PhamePost.php
··· 282 282 return ($this->bloggerPHID == $phid); 283 283 } 284 284 285 - public function shouldShowSubscribersProperty() { 286 - return true; 287 - } 288 - 289 285 290 286 /* -( PhabricatorConduitResultInterface )---------------------------------- */ 291 287
-4
src/applications/pholio/storage/PholioMock.php
··· 184 184 return ($this->authorPHID == $phid); 185 185 } 186 186 187 - public function shouldShowSubscribersProperty() { 188 - return true; 189 - } 190 - 191 187 192 188 /* -( PhabricatorPolicyInterface Implementation )-------------------------- */ 193 189
-3
src/applications/phriction/storage/PhrictionDocument.php
··· 194 194 return false; 195 195 } 196 196 197 - public function shouldShowSubscribersProperty() { 198 - return true; 199 - } 200 197 201 198 /* -( PhabricatorApplicationTransactionInterface )------------------------- */ 202 199
-3
src/applications/phurl/storage/PhabricatorPhurlURL.php
··· 169 169 return ($phid == $this->getAuthorPHID()); 170 170 } 171 171 172 - public function shouldShowSubscribersProperty() { 173 - return true; 174 - } 175 172 176 173 /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ 177 174
-4
src/applications/ponder/storage/PonderAnswer.php
··· 219 219 return ($phid == $this->getAuthorPHID()); 220 220 } 221 221 222 - public function shouldShowSubscribersProperty() { 223 - return true; 224 - } 225 - 226 222 227 223 /* -( PhabricatorDestructibleInterface )----------------------------------- */ 228 224
-4
src/applications/ponder/storage/PonderQuestion.php
··· 248 248 return ($phid == $this->getAuthorPHID()); 249 249 } 250 250 251 - public function shouldShowSubscribersProperty() { 252 - return true; 253 - } 254 - 255 251 256 252 /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ 257 253
-4
src/applications/repository/storage/PhabricatorRepositoryCommit.php
··· 443 443 return ($phid == $this->getAuthorPHID()); 444 444 } 445 445 446 - public function shouldShowSubscribersProperty() { 447 - return true; 448 - } 449 - 450 446 451 447 /* -( PhabricatorApplicationTransactionInterface )------------------------- */ 452 448
-4
src/applications/slowvote/storage/PhabricatorSlowvotePoll.php
··· 179 179 return ($phid == $this->getAuthorPHID()); 180 180 } 181 181 182 - public function shouldShowSubscribersProperty() { 183 - return true; 184 - } 185 - 186 182 187 183 /* -( PhabricatorTokenReceiverInterface )---------------------------------- */ 188 184
-5
src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
··· 96 96 return; 97 97 } 98 98 99 - if (!$object->shouldShowSubscribersProperty()) { 100 - // This object doesn't render subscribers in its property list. 101 - return; 102 - } 103 - 104 99 $subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID( 105 100 $object->getPHID()); 106 101 if ($subscribers) {
-13
src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php
··· 13 13 */ 14 14 public function isAutomaticallySubscribed($phid); 15 15 16 - 17 - /** 18 - * Return `true` to indicate that "Subscribers:" should be shown when 19 - * rendering property lists for this object, or `false` to omit the property. 20 - * 21 - * @return bool True to show the "Subscribers:" property. 22 - */ 23 - public function shouldShowSubscribersProperty(); 24 - 25 16 } 26 17 27 18 // TEMPLATE IMPLEMENTATION ///////////////////////////////////////////////////// ··· 31 22 32 23 public function isAutomaticallySubscribed($phid) { 33 24 return false; 34 - } 35 - 36 - public function shouldShowSubscribersProperty() { 37 - return true; 38 25 } 39 26 40 27 */
-4
src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php
··· 218 218 return false; 219 219 } 220 220 221 - public function shouldShowSubscribersProperty() { 222 - return true; 223 - } 224 - 225 221 226 222 /* -( PhabricatorApplicationTransactionInterface )------------------------- */ 227 223