recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Display correct size of binary files in Diffusion

Test Plan: https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/image/header_logo.png

Reviewers: btrahan, epriestley

Reviewed By: btrahan

CC: aran, Korvin

Maniphest Tasks: T1139

Differential Revision: https://secure.phabricator.com/D3961

vrana abd880e3 ede1f472

+9 -2
+4 -2
src/applications/diffusion/controller/DiffusionBrowseFileController.php
··· 885 885 private function buildBinaryCorpus($file_uri, $data) { 886 886 $properties = new PhabricatorPropertyListView(); 887 887 888 + $size = strlen($data); 888 889 $properties->addTextContent( 889 - pht('This is a binary file. It is %d bytes in length.', 890 - number_format(strlen($data))) 890 + pht('This is a binary file. It is %2$s byte(s) in length.', 891 + $size, 892 + PhutilTranslator::getInstance()->formatNumber($size)) 891 893 ); 892 894 893 895 $actions = id(new PhabricatorActionListView())
+5
src/infrastructure/internationalization/PhabricatorBaseEnglishTranslation.php
··· 167 167 '%d Lint Messages', 168 168 ), 169 169 170 + 'This is a binary file. It is %2$s byte(s) in length.' => array( 171 + 'This is a binary file. It is %2$s byte in length.', 172 + 'This is a binary file. It is %2$s bytes in length.', 173 + ), 174 + 170 175 ); 171 176 } 172 177