recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't try to select a nav item if the selected item is explicitly null

Summary: If there are items (like labels) without keys, we incorrectly select the first item with no key in response to a `selectFilter(null)` call.

Test Plan: Called `selectFilter(null)`, didn't get a selected label.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D4428

epriestley ac5520e0 9470ab05

+5 -3
+5 -3
src/view/layout/AphrontSideNavFilterView.php
··· 136 136 } 137 137 } 138 138 139 - $selected_item = $this->menu->getItem($this->selectedFilter); 140 - if ($selected_item) { 141 - $selected_item->addClass('phabricator-menu-item-selected'); 139 + if ($this->selectedFilter !== null) { 140 + $selected_item = $this->menu->getItem($this->selectedFilter); 141 + if ($selected_item) { 142 + $selected_item->addClass('phabricator-menu-item-selected'); 143 + } 142 144 } 143 145 144 146 require_celerity_resource('phabricator-side-menu-view-css');