@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow "differential.createinline" to accept JSON "false" for "isNewFile"
Summary:
See <https://discourse.phabricator-community.org/t/error-creating-inline-comment-via-conduit-api/4535>. See T12678.
This API method currently does not accept a JSON "false", but reasonably should.
Test Plan:
- Called method with "isNewFile: false".
- Before: type error.
- After: inline comment.
Differential Revision: https://secure.phabricator.com/D21522
+1
-1
+1
-1
src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php
+1
-1
src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php
···
100
100
->setChangesetID($cid)
101
101
->setAuthorPHID($request->getUser()->getPHID())
102
102
->setContent($request->getValue('content'))
103
-
->setIsNewFile($request->getValue('isNewFile'))
103
+
->setIsNewFile((int)$request->getValue('isNewFile'))
104
104
->setLineNumber($request->getValue('lineNumber'))
105
105
->setLineLength($request->getValue('lineLength', 0))
106
106
->save();