@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Check if recurrence end date is disabled before saving it.
Summary: Ref T8357, Check if recurrence end date is disabled before saving it.
Test Plan: Create new event, before saving, leave "recurrence end date" unchecked, save, should not get an error.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin
Maniphest Tasks: T8357
Differential Revision: https://secure.phabricator.com/D13212
+6
-4
+6
-4
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
+6
-4
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
···
201
201
PhabricatorCalendarEventTransaction::TYPE_FREQUENCY)
202
202
->setNewValue(array('rule' => $frequency));
203
203
204
-
$xactions[] = id(new PhabricatorCalendarEventTransaction())
205
-
->setTransactionType(
206
-
PhabricatorCalendarEventTransaction::TYPE_RECURRENCE_END_DATE)
207
-
->setNewValue($recurrence_end_date_value);
204
+
if (!$recurrence_end_date_value->isDisabled()) {
205
+
$xactions[] = id(new PhabricatorCalendarEventTransaction())
206
+
->setTransactionType(
207
+
PhabricatorCalendarEventTransaction::TYPE_RECURRENCE_END_DATE)
208
+
->setNewValue($recurrence_end_date_value);
209
+
}
208
210
}
209
211
210
212
$xactions[] = id(new PhabricatorCalendarEventTransaction())