recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Made Changes to Mock and File generation after pushing some methods to superclass

Summary: Ref T2903

Test Plan: Generation working properly. Was broken before.

Reviewers: epriestley

CC: AnhNhan, aran, Korvin

Maniphest Tasks: T2903

Differential Revision: https://secure.phabricator.com/D5844

authored by

deedydas and committed by
epriestley ace8ac83 2b264119

+1 -13
+1 -9
src/applications/files/lipsum/PhabricatorFileTestDataGenerator.php
··· 4 4 extends PhabricatorTestDataGenerator { 5 5 6 6 public function generate() { 7 - $authorPHID = $this->loadAuthorPHID(); 7 + $authorPHID = $this->loadPhabrictorUserPHID(); 8 8 $dimension = 1 << rand(5, 12); 9 9 $image = id(new PhabricatorLipsumMondrianArtist()) 10 10 ->generate($dimension, $dimension); ··· 16 16 $file->setAuthorPHID($authorPHID); 17 17 $file->setMimeType('image/jpeg'); 18 18 return $file->save(); 19 - } 20 - 21 - private function loadPhabrictorUserPHID() { 22 - return $this->loadOneRandom("PhabricatorUser")->getPHID(); 23 - } 24 - 25 - public function loadAuthorPHID() { 26 - return $this->loadPhabrictorUserPHID(); 27 19 } 28 20 }
-4
src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php
··· 65 65 return $mock->save(); 66 66 } 67 67 68 - public function loadPhabrictorUserPHID() { 69 - return $this->loadOneRandom("PhabricatorUser")->getPHID(); 70 - } 71 - 72 68 public function generateTitle() { 73 69 return id(new PhutilLipsumContextFreeGrammar()) 74 70 ->generate();