recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix Ponder Answer query joins, builtins

Summary: Fixes T9234. The joins method was still the old method and the builtin was calling the wrong key.

Test Plan: Test authored builtin, custom search

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T9234

Differential Revision: https://secure.phabricator.com/D13953

Chad Little ad93af83 22dc3c1b

+3 -3
+2 -2
src/applications/ponder/query/PonderQuestionQuery.php
··· 129 129 return $questions; 130 130 } 131 131 132 - private function buildJoinsClause(AphrontDatabaseConnection $conn_r) { 132 + protected function buildJoinClauseParts(AphrontDatabaseConnection $conn_r) { 133 133 $joins = array(); 134 134 135 135 if ($this->answererPHIDs) { ··· 141 141 $this->answererPHIDs); 142 142 } 143 143 144 - return implode(' ', $joins); 144 + return $joins; 145 145 } 146 146 147 147 protected function getPrimaryTableAlias() {
+1 -1
src/applications/ponder/query/PonderQuestionSearchEngine.php
··· 96 96 array($this->requireViewer()->getPHID())); 97 97 case 'answered': 98 98 return $query->setParameter( 99 - 'answererPHIDs', 99 + 'answerers', 100 100 array($this->requireViewer()->getPHID())); 101 101 } 102 102