@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Removed willProcessRequest from DifferentialRevisionLandController
Summary: Ref T8628.
Test Plan: Landed a revision through the web UI
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley, yelirekim
Maniphest Tasks: T8628
Differential Revision: https://secure.phabricator.com/D16572
+5
-12
+5
-12
src/applications/differential/controller/DifferentialRevisionLandController.php
+5
-12
src/applications/differential/controller/DifferentialRevisionLandController.php
···
2
2
3
3
final class DifferentialRevisionLandController extends DifferentialController {
4
4
5
-
private $revisionID;
6
-
private $strategyClass;
7
5
private $pushStrategy;
8
6
9
-
public function willProcessRequest(array $data) {
10
-
$this->revisionID = $data['id'];
11
-
$this->strategyClass = $data['strategy'];
12
-
}
13
-
14
7
public function handleRequest(AphrontRequest $request) {
15
8
$viewer = $this->getViewer();
16
-
17
-
$revision_id = $this->revisionID;
9
+
$revision_id = $request->getURIData('id');
10
+
$strategy_class = $request->getURIData('strategy');
18
11
19
12
$revision = id(new DifferentialRevisionQuery())
20
13
->withIDs(array($revision_id))
···
24
17
return new Aphront404Response();
25
18
}
26
19
27
-
if (is_subclass_of($this->strategyClass, 'DifferentialLandingStrategy')) {
28
-
$this->pushStrategy = newv($this->strategyClass, array());
20
+
if (is_subclass_of($strategy_class, 'DifferentialLandingStrategy')) {
21
+
$this->pushStrategy = newv($strategy_class, array());
29
22
} else {
30
23
throw new Exception(
31
24
pht(
32
25
"Strategy type must be a valid class name and must subclass ".
33
26
"%s. '%s' is not a subclass of %s",
34
27
'DifferentialLandingStrategy',
35
-
$this->strategyClass,
28
+
$strategy_class,
36
29
'DifferentialLandingStrategy'));
37
30
}
38
31