@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make Ponder Emails a little more consistently delivered
Summary: Ref T9271, maybe fixes it. This restores feed publishing for answers (broken in D13951) and sends the author of the question an email for new answers. Also, unsure how to pull all question subsribers to the answer email, or is it automagical?
Test Plan: notchad asks a question, chad answers, log into notchad and see that mail was delivered, see feed story.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: revi, Korvin
Maniphest Tasks: T9271
Differential Revision: https://secure.phabricator.com/D14171
+28
-7
+21
src/applications/ponder/editor/PonderAnswerEditor.php
+21
src/applications/ponder/editor/PonderAnswerEditor.php
···
85
85
return true;
86
86
}
87
87
88
+
protected function getMailTo(PhabricatorLiskDAO $object) {
89
+
$phids = array();
90
+
$phids[] = $object->getAuthorPHID();
91
+
$phids[] = $this->requireActor()->getPHID();
92
+
93
+
$question = id(new PonderQuestionQuery())
94
+
->setViewer($this->requireActor())
95
+
->withIDs(array($object->getQuestionID()))
96
+
->executeOne();
97
+
98
+
$phids[] = $question->getAuthorPHID();
99
+
100
+
return $phids;
101
+
}
102
+
103
+
protected function shouldPublishFeedStory(
104
+
PhabricatorLiskDAO $object,
105
+
array $xactions) {
106
+
return true;
107
+
}
108
+
88
109
protected function buildReplyHandler(PhabricatorLiskDAO $object) {
89
110
return id(new PonderAnswerReplyHandler())
90
111
->setMailReceiver($object);
-7
src/applications/ponder/editor/PonderEditor.php
-7
src/applications/ponder/editor/PonderEditor.php
···
7
7
return 'PhabricatorPonderApplication';
8
8
}
9
9
10
-
protected function getMailTo(PhabricatorLiskDAO $object) {
11
-
return array(
12
-
$object->getAuthorPHID(),
13
-
$this->requireActor()->getPHID(),
14
-
);
15
-
}
16
-
17
10
protected function getMailSubjectPrefix() {
18
11
return '[Ponder]';
19
12
}
+7
src/applications/ponder/editor/PonderQuestionEditor.php
+7
src/applications/ponder/editor/PonderQuestionEditor.php
···
209
209
return true;
210
210
}
211
211
212
+
protected function getMailTo(PhabricatorLiskDAO $object) {
213
+
return array(
214
+
$object->getAuthorPHID(),
215
+
$this->requireActor()->getPHID(),
216
+
);
217
+
}
218
+
212
219
protected function shouldPublishFeedStory(
213
220
PhabricatorLiskDAO $object,
214
221
array $xactions) {