@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove unusual explicit calls to policy capability descriptions from Diviner
Summary: Fixes T12015. This is weird and probably got copy/pasted from something else that was also being weird, since the methods were empty and I previously removed them.
Test Plan: Edited a book in Diviner.
Reviewers: chad, avivey
Reviewed By: avivey
Maniphest Tasks: T12015
Differential Revision: https://secure.phabricator.com/D17056
+2
-4
+2
-4
src/applications/diviner/controller/DivinerBookEditController.php
+2
-4
src/applications/diviner/controller/DivinerBookEditController.php
···
92
92
->setName('viewPolicy')
93
93
->setPolicyObject($book)
94
94
->setCapability($view_capability)
95
-
->setPolicies($policies)
96
-
->setCaption($book->describeAutomaticCapability($view_capability)))
95
+
->setPolicies($policies))
97
96
->appendChild(
98
97
id(new AphrontFormPolicyControl())
99
98
->setName('editPolicy')
100
99
->setPolicyObject($book)
101
100
->setCapability($edit_capability)
102
-
->setPolicies($policies)
103
-
->setCaption($book->describeAutomaticCapability($edit_capability)))
101
+
->setPolicies($policies))
104
102
->appendChild(
105
103
id(new AphrontFormSubmitControl())
106
104
->setValue(pht('Save'))