+1 -1

src/__phutil_library_map__.php

reviewed

··· 2286 2286 'PhabricatorRepositoryCommitParserWorker' => 'applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php', 2287 2287 'PhabricatorRepositoryCommitRef' => 'applications/repository/engine/PhabricatorRepositoryCommitRef.php', 2288 2288 'PhabricatorRepositoryCommitSearchIndexer' => 'applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php', 2289 2289 - 'PhabricatorRepositoryConfigOptions' => 'applications/repository/PhabricatorRepositoryConfigOptions.php', 2289 2289 + 'PhabricatorRepositoryConfigOptions' => 'applications/repository/config/PhabricatorRepositoryConfigOptions.php', 2290 2290 'PhabricatorRepositoryController' => 'applications/repository/controller/PhabricatorRepositoryController.php', 2291 2291 'PhabricatorRepositoryDAO' => 'applications/repository/storage/PhabricatorRepositoryDAO.php', 2292 2292 'PhabricatorRepositoryDiscoveryEngine' => 'applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php',

+19 -11

src/applications/config/controller/PhabricatorConfigListController.php

reviewed

··· 11 11 $nav->selectFilter('/'); 12 12 13 13 $groups = PhabricatorApplicationConfigOptions::loadAll(); 14 14 - $list = $this->buildConfigOptionsList($groups); 14 14 + $core_list = $this->buildConfigOptionsList($groups, 'core'); 15 15 + $apps_list = $this->buildConfigOptionsList($groups, 'apps'); 15 16 16 17 $title = pht('Phabricator Configuration'); 17 18 18 18 - $box = id(new PHUIObjectBoxView()) 19 19 + $core = id(new PHUIObjectBoxView()) 19 20 ->setHeaderText($title) 20 20 - ->appendChild($list); 21 21 + ->appendChild($core_list); 22 22 + 23 23 + $apps = id(new PHUIObjectBoxView()) 24 24 + ->setHeaderText(pht('Applications Configuration')) 25 25 + ->appendChild($apps_list); 21 26 22 27 $nav->appendChild( 23 28 array( 24 24 - $box, 29 29 + $core, 30 30 + $apps, 25 31 )); 26 32 27 33 $crumbs = $this ··· 37 43 )); 38 44 } 39 45 40 40 - private function buildConfigOptionsList(array $groups) { 46 46 + private function buildConfigOptionsList(array $groups, $type) { 41 47 assert_instances_of($groups, 'PhabricatorApplicationConfigOptions'); 42 48 43 49 $list = new PHUIObjectItemListView(); 44 50 $list->setStackable(true); 45 51 $groups = msort($groups, 'getName'); 46 52 foreach ($groups as $group) { 47 47 - $item = id(new PHUIObjectItemView()) 48 48 - ->setHeader($group->getName()) 49 49 - ->setHref('/config/group/'.$group->getKey().'/') 50 50 - ->addAttribute($group->getDescription()) 51 51 - ->setFontIcon($group->getFontIcon()); 52 52 - $list->addItem($item); 53 53 + if ($group->getGroup() == $type) { 54 54 + $item = id(new PHUIObjectItemView()) 55 55 + ->setHeader($group->getName()) 56 56 + ->setHref('/config/group/'.$group->getKey().'/') 57 57 + ->addAttribute($group->getDescription()) 58 58 + ->setFontIcon($group->getFontIcon()); 59 59 + $list->addItem($item); 60 60 + } 53 61 } 54 62 55 63 return $list;

+4

src/applications/config/option/PhabricatorAWSConfigOptions.php

reviewed

··· 15 15 return 'fa-server'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('amazon-ses.access-key', 'string', null)

+4

src/applications/config/option/PhabricatorAccessLogConfigOptions.php

reviewed

··· 15 15 return 'fa-list'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $common_map = array( 20 24 'C' => pht('The controller or workflow which handled the request.'),

+4

src/applications/config/option/PhabricatorAuthenticationConfigOptions.php

reviewed

··· 15 15 return 'fa-key'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('auth.require-email-verification', 'bool', false)

+4

src/applications/config/option/PhabricatorClusterConfigOptions.php

reviewed

··· 15 15 return 'fa-sitemap'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('cluster.addresses', 'list<string>', array())

+4

src/applications/config/option/PhabricatorCoreConfigOptions.php

reviewed

··· 15 15 return 'fa-bullseye'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 if (phutil_is_windows()) { 20 24 $paths = array();

+4

src/applications/config/option/PhabricatorDeveloperConfigOptions.php

reviewed

··· 15 15 return 'fa-bug'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('darkconsole.enabled', 'bool', false)

+4

src/applications/config/option/PhabricatorDisqusConfigOptions.php

reviewed

··· 15 15 return 'fa-comment'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('disqus.shortname', 'string', null)

+4

src/applications/config/option/PhabricatorExtendingPhabricatorConfigOptions.php

reviewed

··· 15 15 return 'fa-rocket'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('load-libraries', 'list<string>', array())

+4

src/applications/config/option/PhabricatorGarbageCollectorConfigOptions.php

reviewed

··· 15 15 return 'fa-trash-o'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 20 24 $options = array(

+4

src/applications/config/option/PhabricatorMailgunConfigOptions.php

reviewed

··· 15 15 return 'fa-send-o'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('mailgun.domain', 'string', null)

+4

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

reviewed

··· 15 15 return 'fa-send'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $send_as_user_desc = $this->deformat(pht(<<<EODOC 20 24 When a user takes an action which generates an email notification (like

+4

src/applications/config/option/PhabricatorMySQLConfigOptions.php

reviewed

··· 15 15 return 'fa-database'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('mysql.host', 'string', 'localhost')

+4

src/applications/config/option/PhabricatorNotificationConfigOptions.php

reviewed

··· 15 15 return 'fa-bell'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('notification.enabled', 'bool', false)

+4

src/applications/config/option/PhabricatorPHDConfigOptions.php

reviewed

··· 15 15 return 'fa-pied-piper-alt'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('phd.pid-directory', 'string', '/var/tmp/phd/pid')

+4

src/applications/config/option/PhabricatorPHPMailerConfigOptions.php

reviewed

··· 15 15 return 'fa-send-o'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('phpmailer.mailer', 'string', 'smtp')

+4

src/applications/config/option/PhabricatorRecaptchaConfigOptions.php

reviewed

··· 15 15 return 'fa-recycle'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 20 24 return array(

+4

src/applications/config/option/PhabricatorSMSConfigOptions.php

reviewed

··· 15 15 return 'fa-mobile'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $adapter_description = $this->deformat(pht(<<<EODOC 20 24 Adapter class to use to transmit SMS to an external provider. A given external

+4

src/applications/config/option/PhabricatorSecurityConfigOptions.php

reviewed

··· 15 15 return 'fa-lock'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $support_href = PhabricatorEnv::getDoclink('Give Feedback! Get Support!'); 20 24

+4

src/applications/config/option/PhabricatorSendGridConfigOptions.php

reviewed

··· 15 15 return 'fa-send-o'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('sendgrid.api-user', 'string', null)

+4

src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php

reviewed

··· 15 15 return 'fa-code'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 20 24 $caches_href = PhabricatorEnv::getDocLink('Managing Caches');

+4

src/applications/config/option/PhabricatorTranslationsConfigOptions.php

reviewed

··· 15 15 return 'fa-globe'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption(

+4

src/applications/config/option/PhabricatorUIConfigOptions.php

reviewed

··· 15 15 return 'fa-magnet'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $manifest = PHUIIconView::getSheetManifest('main-header'); 20 24

+4

src/applications/conpherence/config/ConpherenceConfigOptions.php

reviewed

··· 15 15 return 'fa-comments'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption(

+4

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

reviewed

··· 15 15 return 'fa-cog'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $custom_field_type = 'custom:PhabricatorCustomFieldConfigOptionType'; 20 24

+4

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

reviewed

··· 15 15 return 'fa-code'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption(

+4

src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php

reviewed

··· 15 15 return 'fa-exchange'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'core'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('asana.workspace-id', 'string', null)

+4

src/applications/feed/config/PhabricatorFeedConfigOptions.php

reviewed

··· 15 15 return 'fa-newspaper-o'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('feed.public', 'bool', false)

+4

src/applications/files/config/PhabricatorFilesConfigOptions.php

reviewed

··· 15 15 return 'fa-file'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $viewable_default = array( 20 24 'image/jpeg' => 'image/jpeg',

+4

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php

reviewed

··· 15 15 return 'fa-ship'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array(); 20 24 }

+4

src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php

reviewed

··· 15 15 return 'fa-gavel'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption(

+4

src/applications/macro/config/PhabricatorMacroConfigOptions.php

reviewed

··· 15 15 return 'fa-file-image-o'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('metamta.macro.reply-handler-domain', 'string', null)

+4

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

reviewed

··· 15 15 return 'fa-anchor'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 20 24 $priority_defaults = array(

+4

src/applications/owners/config/PhabricatorOwnersConfigOptions.php

reviewed

··· 15 15 return 'fa-gift'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption(

+4

src/applications/paste/config/PhabricatorPasteConfigOptions.php

reviewed

··· 15 15 return 'fa-paste'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption(

+4

src/applications/people/config/PhabricatorUserConfigOptions.php

reviewed

··· 15 15 return 'fa-users'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 20 24 $default = array(

+4

src/applications/phame/config/PhabricatorPhameConfigOptions.php

reviewed

··· 15 15 return 'fa-star'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption(

+4

src/applications/pholio/config/PhabricatorPholioConfigOptions.php

reviewed

··· 15 15 return 'fa-camera-retro'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('metamta.pholio.reply-handler-domain', 'string', null)

+4

src/applications/phrequent/config/PhabricatorPhrequentConfigOptions.php

reviewed

··· 15 15 return 'fa-clock-o'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array(); 20 24 }

+4

src/applications/phriction/config/PhabricatorPhrictionConfigOptions.php

reviewed

··· 15 15 return 'fa-book'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption(

+4

src/applications/policy/config/PhabricatorPolicyConfigOptions.php

reviewed

··· 15 15 return 'fa-lock'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $policy_locked_type = 'custom:PolicyLockOptionType'; 20 24 $policy_locked_example = array(

+4

src/applications/project/config/PhabricatorProjectConfigOptions.php

reviewed

··· 15 15 return 'fa-briefcase'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $default_fields = array( 20 24 'std:project:internal:description' => true,

+4

src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php

reviewed

··· 15 15 return 'fa-flag-checkered'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 $default_fields = array( 20 24 new ReleephSummaryFieldSpecification(),

+4

src/applications/repository/PhabricatorRepositoryConfigOptions.php src/applications/repository/config/PhabricatorRepositoryConfigOptions.php

reviewed

··· 15 15 return 'fa-hdd-o'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption('repository.default-local-path', 'string', '/var/repo/')

+4

src/applications/search/config/PhabricatorSearchConfigOptions.php

reviewed

··· 15 15 return 'fa-search'; 16 16 } 17 17 18 18 + public function getGroup() { 19 19 + return 'apps'; 20 20 + } 21 21 + 18 22 public function getOptions() { 19 23 return array( 20 24 $this->newOption(