@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move DiffusionHistoryListView to DiffusionCommitListView
Summary: I think this name is more accurate, also add proper links to author image.
Test Plan: Review commits in sandbox, see new URL on image.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D18026
+7
-4
+2
-2
src/__phutil_library_map__.php
+2
-2
src/__phutil_library_map__.php
···
661
661
'DiffusionCommitHookEngine' => 'applications/diffusion/engine/DiffusionCommitHookEngine.php',
662
662
'DiffusionCommitHookRejectException' => 'applications/diffusion/exception/DiffusionCommitHookRejectException.php',
663
663
'DiffusionCommitListController' => 'applications/diffusion/controller/DiffusionCommitListController.php',
664
+
'DiffusionCommitListView' => 'applications/diffusion/view/DiffusionCommitListView.php',
664
665
'DiffusionCommitMergeHeraldField' => 'applications/diffusion/herald/DiffusionCommitMergeHeraldField.php',
665
666
'DiffusionCommitMessageHeraldField' => 'applications/diffusion/herald/DiffusionCommitMessageHeraldField.php',
666
667
'DiffusionCommitPackageAuditHeraldField' => 'applications/diffusion/herald/DiffusionCommitPackageAuditHeraldField.php',
···
728
729
'DiffusionGitSSHWorkflow' => 'applications/diffusion/ssh/DiffusionGitSSHWorkflow.php',
729
730
'DiffusionGitUploadPackSSHWorkflow' => 'applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php',
730
731
'DiffusionHistoryController' => 'applications/diffusion/controller/DiffusionHistoryController.php',
731
-
'DiffusionHistoryListView' => 'applications/diffusion/view/DiffusionHistoryListView.php',
732
732
'DiffusionHistoryQueryConduitAPIMethod' => 'applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php',
733
733
'DiffusionHistoryTableView' => 'applications/diffusion/view/DiffusionHistoryTableView.php',
734
734
'DiffusionHovercardEngineExtension' => 'applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php',
···
5634
5634
'DiffusionCommitHookEngine' => 'Phobject',
5635
5635
'DiffusionCommitHookRejectException' => 'Exception',
5636
5636
'DiffusionCommitListController' => 'DiffusionController',
5637
+
'DiffusionCommitListView' => 'AphrontView',
5637
5638
'DiffusionCommitMergeHeraldField' => 'DiffusionCommitHeraldField',
5638
5639
'DiffusionCommitMessageHeraldField' => 'DiffusionCommitHeraldField',
5639
5640
'DiffusionCommitPackageAuditHeraldField' => 'DiffusionCommitHeraldField',
···
5704
5705
),
5705
5706
'DiffusionGitUploadPackSSHWorkflow' => 'DiffusionGitSSHWorkflow',
5706
5707
'DiffusionHistoryController' => 'DiffusionController',
5707
-
'DiffusionHistoryListView' => 'AphrontView',
5708
5708
'DiffusionHistoryQueryConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod',
5709
5709
'DiffusionHistoryTableView' => 'DiffusionView',
5710
5710
'DiffusionHovercardEngineExtension' => 'PhabricatorHovercardEngineExtension',
+4
-1
src/applications/diffusion/view/DiffusionHistoryListView.php
src/applications/diffusion/view/DiffusionCommitListView.php
+4
-1
src/applications/diffusion/view/DiffusionHistoryListView.php
src/applications/diffusion/view/DiffusionCommitListView.php
···
1
1
<?php
2
2
3
-
final class DiffusionHistoryListView extends AphrontView {
3
+
final class DiffusionCommitListView extends AphrontView {
4
4
5
5
private $commits = array();
6
6
private $noDataString;
···
114
114
if ($author_phid) {
115
115
$author_name = $handles[$author_phid]->renderLink();
116
116
$author_image_uri = $handles[$author_phid]->getImageURI();
117
+
$author_image_href = $handles[$author_phid]->getURI();
117
118
} else {
118
119
$author_name = $commit->getCommitData()->getAuthorName();
119
120
$author_image_uri =
120
121
celerity_get_resource_uri('/rsrc/image/people/user0.png');
122
+
$author_image_href = null;
121
123
}
122
124
123
125
$commit_tag = id(new PHUITagView())
···
132
134
->setDisabled($commit->isUnreachable())
133
135
->setDescription($message)
134
136
->setImageURI($author_image_uri)
137
+
->setImageHref($author_image_href)
135
138
->addByline(pht('Author: %s', $author_name))
136
139
->addIcon('none', $committed)
137
140
->addAttribute($commit_tag);
+1
-1
src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php
+1
-1
src/applications/people/controller/PhabricatorPeopleProfileCommitsController.php