+17 -17

resources/celerity/map.php

reviewed

··· 10 10 'conpherence.pkg.css' => 'b2d6f4b8', 11 11 'conpherence.pkg.js' => '020aebcf', 12 12 'core.pkg.css' => 'eeb65c02', 13 13 - 'core.pkg.js' => '9250c090', 13 13 + 'core.pkg.js' => '33424d18', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => 'abdb4fe9', 16 16 'differential.pkg.js' => '46fcb3af', ··· 216 216 'rsrc/externals/javelin/ext/view/__tests__/ViewInterpreter.js' => 'a9f35511', 217 217 'rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js' => '3a1b81f6', 218 218 'rsrc/externals/javelin/lib/Cookie.js' => '05d290ef', 219 219 - 'rsrc/externals/javelin/lib/DOM.js' => 'e4c7622a', 219 219 + 'rsrc/externals/javelin/lib/DOM.js' => '3c6f9405', 220 220 'rsrc/externals/javelin/lib/History.js' => '030b4f7a', 221 221 'rsrc/externals/javelin/lib/JSON.js' => '541f81c3', 222 222 'rsrc/externals/javelin/lib/Leader.js' => '0d2490ce', ··· 228 228 'rsrc/externals/javelin/lib/Router.js' => '32755edb', 229 229 'rsrc/externals/javelin/lib/Scrollbar.js' => 'a43ae2ae', 230 230 'rsrc/externals/javelin/lib/Sound.js' => 'd4cc2d2a', 231 231 - 'rsrc/externals/javelin/lib/URI.js' => '2e255291', 231 231 + 'rsrc/externals/javelin/lib/URI.js' => '1fcfd5c0', 232 232 'rsrc/externals/javelin/lib/Vector.js' => 'e9c80beb', 233 233 'rsrc/externals/javelin/lib/WebSocket.js' => 'fdc13e4e', 234 234 'rsrc/externals/javelin/lib/Workflow.js' => 'cc1553f3', ··· 639 639 'javelin-color' => '78f811c9', 640 640 'javelin-cookie' => '05d290ef', 641 641 'javelin-diffusion-locate-file-source' => '6c798a10', 642 642 - 'javelin-dom' => 'e4c7622a', 642 642 + 'javelin-dom' => '3c6f9405', 643 643 'javelin-dynval' => '202a2e85', 644 644 'javelin-event' => '1dbe260d', 645 645 'javelin-external-editor-link-engine' => '48a8641f', ··· 670 670 'javelin-typeahead-preloaded-source' => '5a79f6c3', 671 671 'javelin-typeahead-source' => '8badee71', 672 672 'javelin-typeahead-static-source' => '80bff3af', 673 673 - 'javelin-uri' => '2e255291', 673 673 + 'javelin-uri' => '1fcfd5c0', 674 674 'javelin-util' => '472cda1c', 675 675 'javelin-vector' => 'e9c80beb', 676 676 'javelin-view' => '289bf236', ··· 1001 1001 'javelin-stratcom', 1002 1002 'javelin-util', 1003 1003 ), 1004 1004 + '1fcfd5c0' => array( 1005 1005 + 'javelin-install', 1006 1006 + 'javelin-util', 1007 1007 + 'javelin-stratcom', 1008 1008 + ), 1004 1009 '202a2e85' => array( 1005 1010 'javelin-install', 1006 1011 'javelin-reactornode', ··· 1089 1094 'javelin-request', 1090 1095 'phabricator-shaped-request', 1091 1096 ), 1092 1092 - '2e255291' => array( 1093 1093 - 'javelin-install', 1094 1094 - 'javelin-util', 1095 1095 - 'javelin-stratcom', 1096 1096 - ), 1097 1097 '2f1db1ed' => array( 1098 1098 'javelin-util', 1099 1099 ), ··· 1148 1148 '3b4899b0' => array( 1149 1149 'javelin-behavior', 1150 1150 'phabricator-prefab', 1151 1151 + ), 1152 1152 + '3c6f9405' => array( 1153 1153 + 'javelin-magical-init', 1154 1154 + 'javelin-install', 1155 1155 + 'javelin-util', 1156 1156 + 'javelin-vector', 1157 1157 + 'javelin-stratcom', 1151 1158 ), 1152 1159 '3dc5ad43' => array( 1153 1160 'javelin-behavior', ··· 2054 2061 'javelin-install', 2055 2062 'javelin-dom', 2056 2063 'javelin-json', 2057 2057 - ), 2058 2058 - 'e4c7622a' => array( 2059 2059 - 'javelin-magical-init', 2060 2060 - 'javelin-install', 2061 2061 - 'javelin-util', 2062 2062 - 'javelin-vector', 2063 2063 - 'javelin-stratcom', 2064 2064 ), 2065 2065 'e5bdb730' => array( 2066 2066 'javelin-behavior',

+1 -1

src/aphront/AphrontRequest.php

reviewed

··· 795 795 $try_names[] = 'HTTP_'.$php_index; 796 796 if ($php_index == 'CONTENT_TYPE' || $php_index == 'CONTENT_LENGTH') { 797 797 // These headers may be available under alternate names. See 798 798 - // http://www.php.net/manual/en/reserved.variables.server.php#110763 798 798 + // https://www.php.net/manual/reserved.variables.server.php#110763 799 799 $try_names[] = $php_index; 800 800 } 801 801

+2 -2

src/aphront/sink/AphrontHTTPSink.php

reviewed

··· 65 65 // Attackers may perform an "HTTP response splitting" attack by making 66 66 // the application emit certain types of headers containing newlines: 67 67 // 68 68 - // http://en.wikipedia.org/wiki/HTTP_response_splitting 68 68 + // https://en.wikipedia.org/wiki/HTTP_response_splitting 69 69 // 70 70 // PHP has built-in protections against HTTP response-splitting, but they 71 71 // are of dubious trustworthiness: 72 72 // 73 73 - // http://news.php.net/php.internals/57655 73 73 + // https://news-web.php.net/php.internals/57655 74 74 75 75 if (preg_match('/[\r\n\0]/', $name.$value)) { 76 76 throw new Exception(

+1 -1

src/applications/config/check/PhabricatorBaseURISetupCheck.php

reviewed

··· 76 76 'will not work properly until you configure it.'. 77 77 "\n\n". 78 78 'You should set the base URI to the URI you will use to access '. 79 79 - 'this server, like "http://devtools.example.com/".'. 79 79 + 'this server, like "https://devtools.example.com/".'. 80 80 "\n\n". 81 81 'Include the protocol (http or https), domain name, and port number if '. 82 82 'you are using a port other than 80 (http) or 443 (https).'.

+8 -8

src/applications/config/option/PhabricatorCoreConfigOptions.php

reviewed

··· 79 79 'improves security by preventing cookies from being set on other '. 80 80 'domains, and allows daemons to send emails with links that have '. 81 81 'the correct domain.')) 82 82 - ->addExample('http://devtools.example.com/', pht('Valid Setting')), 82 82 + ->addExample('https://devtools.example.com/', pht('Valid Setting')), 83 83 $this->newOption('phabricator.production-uri', 'string', null) 84 84 ->setSummary( 85 85 pht('Primary install URI, for multi-environment installs.')) ··· 93 93 'installs do not need to set this option.', 94 94 PlatformSymbols::getPlatformServerName(), 95 95 'phabricator.base-uri')) 96 96 - ->addExample('http://devtools.example.com/', pht('Valid Setting')), 96 96 + ->addExample('https://devtools.example.com/', pht('Valid Setting')), 97 97 $this->newOption('phabricator.allowed-uris', 'list<string>', array()) 98 98 ->setLocked(true) 99 99 ->setSummary(pht('Alternative URIs that can access this service.')) ··· 104 104 "won't work. The major use case for this is moving installs ". 105 105 "across domains.")) 106 106 ->addExample( 107 107 - "http://phabricator2.example.com/\n". 108 108 - "http://phabricator3.example.com/", 107 107 + "https://phorge2.example.com/\n". 108 108 + "https://phorge3.example.com/", 109 109 pht('Valid Setting')), 110 110 $this->newOption('phabricator.timezone', 'string', null) 111 111 ->setSummary( ··· 297 297 'browsers will not set cookies on domains with no TLD.', 298 298 $key, 299 299 '.', 300 300 - 'http://example.com/', 301 301 - 'http://example/')); 300 300 + 'https://example.com/', 301 301 + 'https://example/')); 302 302 } 303 303 304 304 $path = $uri->getPath(); ··· 309 309 "e.g. '%s' is OK, but '%s' is not. This software must be '. 310 310 'installed on an entire domain; it can not be installed on a path.", 311 311 $key, 312 312 - 'http://devtools.example.com/', 313 313 - 'http://example.com/devtools/')); 312 312 + 'https://devtools.example.com/', 313 313 + 'https://example.com/devtools/')); 314 314 } 315 315 } 316 316

+2 -2

src/applications/files/config/PhabricatorFilesConfigOptions.php

reviewed

··· 34 34 'text/x-diff' => 'text/plain; charset=utf-8', 35 35 36 36 // ".ico" favicon files, which have mime type diversity. See: 37 37 - // http://en.wikipedia.org/wiki/ICO_(file_format)#MIME_type 37 37 + // https://en.wikipedia.org/wiki/ICO_(file_format)#MIME_type 38 38 'image/x-ico' => 'image/x-icon', 39 39 'image/x-icon' => 'image/x-icon', 40 40 'image/vnd.microsoft.icon' => 'image/x-icon', ··· 92 92 'application/ogg' => true, 93 93 ); 94 94 95 95 - // largely lifted from http://en.wikipedia.org/wiki/Internet_media_type 95 95 + // largely lifted from https://en.wikipedia.org/wiki/Internet_media_type 96 96 $icon_default = array( 97 97 // audio file icon 98 98 'audio/basic' => 'fa-file-audio-o',

+10 -10

src/applications/reference/src/controller/RemarkupReferenceController.php

reviewed

··· 35 35 #project # Mention a Project 36 36 [[wiki page]] # Link to Phriction 37 37 [[wiki page | name]] # Named link to Phriction 38 38 - http://xyz/ # Link to web 39 39 - [[http://xyz/ | name]] # Named link to web 40 40 - [name](http://xyz/) # Alternate Link 38 38 + https://xyz/ # Link to web 39 39 + [[https://xyz/ | name]] # Named link to web 40 40 + [name](https://xyz/) # Alternate Link 41 41 42 42 These are block styles, and must be separated from surrounding text by 43 43 empty lines: ··· 347 347 348 348 = Linking URIs = 349 349 350 350 - URIs are automatically linked: http://phorge.it/ 350 350 + URIs are automatically linked: https://phorge.it/ 351 351 352 352 If you have a URI with problematic characters in it, like 353 353 - "`http://comma.org/,`", you can surround it with angle brackets: 353 353 + "`https://example.com/,`", you can surround it with angle brackets: 354 354 355 355 - <http://comma.org/,> 355 355 + <https://example.com/,> 356 356 357 357 - This will force the parser to consume the whole URI: <http://comma.org/,> 357 357 + This will force the parser to consume the whole URI: <https://example.com/,> 358 358 359 359 You can also use create named links, where you choose the displayed text. These 360 360 work within Phorge or on the internet at large: 361 361 362 362 [[/herald/transcript/ | Herald Transcripts]] 363 363 - [[http://www.boring-legal-documents.com/ | exciting legal documents]] 363 363 + [[https://boring.example.com/ | exciting example]] 364 364 365 365 Markdown-style links are also supported: 366 366 367 367 - [Toil](http://www.trouble.com) 367 367 + [Example](https://www.example.com) 368 368 369 369 = Linking to Objects = 370 370 ··· 595 595 To place text in a literal block use `%%%`: 596 596 597 597 %%%Text that won't be processed by remarkup 598 598 - [[http://www.example.com | example]] 598 598 + [[https://www.example.com | example]] 599 599 %%% 600 600 601 601 Remarkup will not process the text inside of literal blocks (other than to

+1 -1

src/docs/contributor/describing_problems.diviner

reviewed

··· 144 144 145 145 - [[ http://www.catb.org/esr/faqs/smart-questions.html | How To Ask 146 146 Questions The Smart Way ]], by Eric S. Raymond 147 147 - - [[ http://xyproblem.info | XY Problem ]] 147 147 + - [[ https://xyproblem.info/ | XY Problem ]] 148 148 - [[ https://en.wikipedia.org/wiki/5_Whys | 5 Whys Technique ]] 149 149 150 150 Asking good questions and describing problems clearly is an important,

+1 -1

src/docs/contributor/using_oauthserver.diviner

reviewed

··· 9 9 `Authorization Code Grant` flow as described in the OAuth 2.0 10 10 specification: 11 11 12 12 - http://tools.ietf.org/html/draft-ietf-oauth-v2-23 12 12 + https://datatracker.ietf.org/doc/html/draft-ietf-oauth-v2-23 13 13 14 14 This functionality can allow clients to integrate with a given 15 15 Phorge instance in a secure way with granular data access.

+1 -1

src/docs/user/configuration/configuring_inbound_email.diviner

reviewed

··· 174 174 ============= 175 175 176 176 To use Mailgun, you need a Mailgun account. You can sign up at 177 177 - <http://www.mailgun.com>. Provided you have such an account, configure it 177 177 + <https://www.mailgun.com>. Provided you have such an account, configure it 178 178 like this: 179 179 180 180 - Configure a mail domain according to Mailgun's instructions.

+1 -1

src/docs/user/userguide/amazon_rds.diviner

reviewed

··· 21 21 configuration changes in `my.cnf`. In Amazon RDS, you don't have direct access 22 22 to `my.cnf` and thus can not make these changes in the configuration file. 23 23 24 24 - Instead, you can use [[ http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_WorkingWithParamGroups.html | DB Parameter Groups ]]. 24 24 + Instead, you can use [[ https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_WorkingWithParamGroups.html | DB Parameter Groups ]]. 25 25 You can access these from your AWS console and use the web interface to make 26 26 necessary changes. The web UI will give you a user-friendly key-value table: 27 27 just identify the option you need to change, then select a new value for it.

+1 -1

src/docs/user/userguide/arcanist_windows.diviner

reviewed

··· 45 45 You can configure various programs for this purpose, depending on which text 46 46 editor you prefer. Some editors that will work are: 47 47 48 48 - - [[ http://notepad-plus-plus.org/ | Notepad++ ]], a good all-around editor. 48 48 + - [[ https://notepad-plus-plus.org/ | Notepad++ ]], a good all-around editor. 49 49 - **vim**, which comes with Git Bash. 50 50 - [[ https://www.sublimetext.com/ | Sublime Text ]]. 51 51

+1 -1

src/docs/user/userguide/diffusion_symbols.diviner

reviewed

··· 31 31 32 32 Phorge also includes a script which can identify symbols in any 33 33 programming language that has classes and/or functions, and is supported by 34 34 - Exuberant Ctags (http://ctags.sourceforge.net): 34 34 + Exuberant Ctags (https://ctags.sourceforge.net): 35 35 36 36 ./scripts/symbols/generate_ctags_symbols.php 37 37

+2 -2

src/docs/user/userguide/diviner.diviner

reviewed

··· 35 35 "title" : "Example Documentation", 36 36 "short" : "Example Docs", 37 37 "root" : ".", 38 38 - "uri.source" : "http://example.com/diffusion/X/browse/master/%f$%l", 38 38 + "uri.source" : "https://example.com/diffusion/X/browse/master/%f$%l", 39 39 "rules" : { 40 40 "(\\.diviner$)" : "DivinerArticleAtomizer" 41 41 }, ··· 76 76 repository browser so that you can quickly jump to the definition of a class 77 77 or function. To do this, it uses a URI pattern which you specify here. 78 78 Normally, this URI should point at a repository browser like Diffusion. 79 79 - For example, `"http://repobrowser.yourcompany.com/%f#%l"`. You can use these 79 79 + For example, `"https://repobrowser.example.com/%f#%l"`. You can use these 80 80 conversions in the URI, which will be replaced at runtime: 81 81 - `%f`: Replaced with the name of the file. 82 82 - `%l`: Replaced with the line number.

+10 -10

src/docs/user/userguide/remarkup.diviner

reviewed

··· 28 28 #project # Mention a Project 29 29 [[wiki page]] # Link to Phriction 30 30 [[wiki page | name]] # Named link to Phriction 31 31 - http://xyz/ # Link to web 32 32 - [[http://xyz/ | name]] # Named link to web 33 33 - [name](http://xyz/) # Alternate Link 31 31 + https://xyz/ # Link to web 32 32 + [[https://xyz/ | name]] # Named link to web 33 33 + [name](https://xyz/) # Alternate Link 34 34 35 35 These are block styles, and must be separated from surrounding text by 36 36 empty lines: ··· 340 340 341 341 = Linking URIs = 342 342 343 343 - URIs are automatically linked: http://phorge.it/ 343 343 + URIs are automatically linked: https://phorge.it/ 344 344 345 345 If you have a URI with problematic characters in it, like 346 346 - "`http://comma.org/,`", you can surround it with angle brackets: 346 346 + "`https://example.com/,`", you can surround it with angle brackets: 347 347 348 348 - <http://comma.org/,> 348 348 + <https://example.com/,> 349 349 350 350 - This will force the parser to consume the whole URI: <http://comma.org/,> 350 350 + This will force the parser to consume the whole URI: <https://example.com/,> 351 351 352 352 You can also use create named links, where you choose the displayed text. These 353 353 work within Phorge or on the internet at large: 354 354 355 355 [[/herald/transcript/ | Herald Transcripts]] 356 356 - [[http://www.boring-legal-documents.com/ | exciting legal documents]] 356 356 + [[https://boring.example.com/ | exciting example]] 357 357 358 358 Markdown-style links are also supported: 359 359 360 360 - [Toil](http://www.trouble.com) 360 360 + [Example](https://www.example.com) 361 361 362 362 = Linking to Objects = 363 363 ··· 589 589 To place text in a literal block use `%%%`: 590 590 591 591 %%%Text that won't be processed by remarkup 592 592 - [[http://www.example.com | example]] 592 592 + [[https://www.example.com | example]] 593 593 %%% 594 594 595 595 Remarkup will not process the text inside of literal blocks (other than to

+4 -4

src/infrastructure/markup/markuprule/PhutilRemarkupHyperlinkRule.php

reviewed

··· 59 59 // Anything else we match "ungreedily", which means we'll look for 60 60 // stuff that's probably puncutation or otherwise not part of the URL and 61 61 // not link it. This lets someone write "QuicK! Go to 62 62 - // http://www.example.com/!". We also apply some paren balancing rules. 62 62 + // https://www.example.com/!". We also apply some paren balancing rules. 63 63 64 64 // NOTE: We're explicitly avoiding capturing stored blocks, so text like 65 65 - // `http://www.example.com/[[x | y]]` doesn't get aggressively captured. 65 65 + // `https://www.example.com/[[x | y]]` doesn't get aggressively captured. 66 66 67 67 $text = preg_replace_callback( 68 68 $bare_pattern, ··· 162 162 // handle the two common paren cases, Wikipedia links and English language 163 163 // parentheticals, e.g.: 164 164 // 165 165 - // http://en.wikipedia.org/wiki/Noun_(disambiguation) 166 166 - // (see also http://www.example.com) 165 165 + // https://en.wikipedia.org/wiki/Noun_(disambiguation) 166 166 + // (see also https://www.example.com) 167 167 // 168 168 // We could apply a craftier heuristic here which tries to actually balance 169 169 // the parens, but this is probably sufficient.

+3 -3

webroot/rsrc/externals/javelin/lib/DOM.js

reviewed

··· 219 219 * 220 220 * JX.$N( 221 221 * 'a', 222 222 - * {href: 'http://www.javelinjs.com'}, 223 223 - * 'Visit the Javelin Homepage'); 222 222 + * {href: 'https://example.com/'}, 223 223 + * 'Visit the Example Homepage'); 224 224 * 225 225 * This is equivalent to: 226 226 * 227 227 * LANG=HTML 228 228 - * <a href="http://www.javelinjs.com">Visit the Javelin Homepage</a> 228 228 + * <a href="https://example.com/">Visit the Example Homepage</a> 229 229 * 230 230 * If you only want to specify content, you can omit the attribute parameter. 231 231 * That is, these calls are equivalent:

+4 -4

webroot/rsrc/externals/javelin/lib/URI.js

reviewed

··· 13 13 * Handy convenience function that returns a @{class:JX.URI} instance. This 14 14 * allows you to write things like: 15 15 * 16 16 - * JX.$U('http://zombo.com/').getDomain(); 16 16 + * JX.$U('https://example.com/').getDomain(); 17 17 * 18 18 * @param string Unparsed URI. 19 19 * @return @{class:JX.URI} JX.URI instance. ··· 25 25 /** 26 26 * Convert a string URI into a maleable object. 27 27 * 28 28 - * var uri = new JX.URI('http://www.example.com/asdf.php?a=b&c=d#anchor123'); 28 28 + * var uri = new JX.URI('https://www.example.com/asdf.php?a=b&c=d#anchor12'); 29 29 * uri.getProtocol(); // http 30 30 * uri.getDomain(); // www.example.com 31 31 * uri.getPath(); // /asdf.php 32 32 * uri.getQueryParams(); // {a: 'b', c: 'd'} 33 33 - * uri.getFragment(); // anchor123 33 33 + * uri.getFragment(); // anchor12 34 34 * 35 35 * ...and back into a string: 36 36 * 37 37 * uri.setFragment('clowntown'); 38 38 - * uri.toString() // http://www.example.com/asdf.php?a=b&c=d#clowntown 38 38 + * uri.toString() // https://www.example.com/asdf.php?a=b&c=d#clowntown 39 39 */ 40 40 JX.install('URI', { 41 41 statics : {