recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't disable the "Show Public Key" action for locked credentials

Summary: Fixes T5104. It's still OK to reveal public keys of locked credentials -- the controller has the right logic, this UI just isn't in sync.

Test Plan: Viewed passphrase; saw enabled menu item on locked credential.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5104

Differential Revision: https://secure.phabricator.com/D9186

epriestley af0edf88 edd82420

+1 -2
+1 -2
src/applications/passphrase/controller/PassphraseCredentialViewController.php
··· 134 134 ->setName(pht('Show Public Key')) 135 135 ->setIcon('fa-download') 136 136 ->setHref($this->getApplicationURI("public/{$id}/")) 137 - ->setWorkflow(true) 138 - ->setDisabled($is_locked)); 137 + ->setWorkflow(true)); 139 138 } 140 139 141 140 $actions->addAction(