recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue where rejecting reviewers weren't powerful enough

Summary:
Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan:
- User A accepts a revision.
- User B rejects it.
- Author updates it.
- Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
- After patch: correctly transitions to "needs review".

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17653

epriestley af1d494d 28941b31

+2
+2
src/applications/differential/editor/DifferentialTransactionEditor.php
··· 672 672 $active_phid = $active_diff->getPHID(); 673 673 if ($reviewer->isRejected($active_phid)) { 674 674 $has_rejecting_reviewer = true; 675 + } else { 676 + $has_rejecting_older_reviewer = true; 675 677 } 676 678 break; 677 679 case DifferentialReviewerStatus::STATUS_REJECTED_OLDER: