@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72
Summary: Closes T16082
Test Plan:
Visit this page:
http://phorge.localhost/calendar/event/edit/form/default/?start=1747749600&end=1747753200
No warning anymore from your Dark Console.
The Start and End fields are still prefixed with '2025-05-20', so, no regressions.
Reviewers: O1 Blessed Committers, mainframe98, aklapper
Reviewed By: O1 Blessed Committers, mainframe98, aklapper
Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T16082
Differential Revision: https://we.phorge.it/D26029
+2
-2
+2
-2
src/view/form/control/AphrontFormDateControlValue.php
+2
-2
src/view/form/control/AphrontFormDateControlValue.php
···
63
63
$value = new AphrontFormDateControlValue();
64
64
$value->viewer = $request->getViewer();
65
65
66
-
$date = $request->getStr($key.'_d');
67
-
$time = $request->getStr($key.'_t');
66
+
$date = $request->getStr($key.'_d', '');
67
+
$time = $request->getStr($key.'_t', '');
68
68
69
69
// If we have the individual parts, we read them preferentially. If we do
70
70
// not, try to read the key as a raw value. This makes it so that HTTP