@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator
Summary: Ref T13660. Clean up callsites to "PhutilExecPassthru->execute()" to prepare to deprecate it.
Test Plan:
- Grepped for "PhutilExecPassthru" and looked for callsites.
- Ran `GIT_SSH=.../ssh-connect git ls-remote origin` to execute the "ssh-connect" code.
- The two passthru future methods have no callers and could possibly be removed, but I'm just letting sleeping dogs lie for now.
Reviewers: cspeckmim
Reviewed By: cspeckmim
Maniphest Tasks: T13660
Differential Revision: https://secure.phabricator.com/D21703
+3
-3
+1
-1
scripts/ssh/ssh-connect.php
+1
-1
scripts/ssh/ssh-connect.php
+2
-2
src/applications/repository/storage/PhabricatorRepository.php
+2
-2
src/applications/repository/storage/PhabricatorRepository.php
···
499
499
500
500
public function passthruRemoteCommand($pattern /* , $arg, ... */) {
501
501
$args = func_get_args();
502
-
return $this->newRemoteCommandPassthru($args)->execute();
502
+
return $this->newRemoteCommandPassthru($args)->resolve();
503
503
}
504
504
505
505
private function newRemoteCommandFuture(array $argv) {
···
540
540
541
541
public function passthruLocalCommand($pattern /* , $arg, ... */) {
542
542
$args = func_get_args();
543
-
return $this->newLocalCommandPassthru($args)->execute();
543
+
return $this->newLocalCommandPassthru($args)->resolve();
544
544
}
545
545
546
546
private function newLocalCommandFuture(array $argv) {