@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Test 0 and "" cases in Project Icon Config
Summary: Better validation for setting a default image in project.icon
Test Plan: Test adding `"0"` and `""` as image options in project.icon, see error.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D18197
+2
-1
+2
-1
src/applications/project/icon/PhabricatorProjectIconSet.php
+2
-1
src/applications/project/icon/PhabricatorProjectIconSet.php
···
262
262
263
263
$is_disabled = idx($value, 'disabled');
264
264
265
-
if (idx($value, 'image')) {
265
+
$image = idx($value, 'image');
266
+
if ($image !== null) {
266
267
$builtin = idx($value, 'image');
267
268
$builtin_map = id(new PhabricatorFilesOnDiskBuiltinFile())
268
269
->getProjectBuiltinFiles();