@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow draft revisions to be commandeered
Summary:
See PHI457. There's no real reason not to allow this, it just wasn't clear if it was useful. See D18626.
An install had a user `arc diff` and then sprint out the door to take a very long vacation before the builds finished. One failed, so the revision is stuck as a draft forever. This seems like a reasonable motivation for allowing "Commandeer".
Test Plan: Successfully commandeered a draft.
Differential Revision: https://secure.phabricator.com/D19228
-5
-5
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
-5
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
···
66
66
'been closed. You can only commandeer open revisions.'));
67
67
}
68
68
69
-
if ($object->isDraft()) {
70
-
throw new Exception(
71
-
pht('You can not commandeer a draft revision.'));
72
-
}
73
-
74
69
if ($this->isViewerRevisionAuthor($object, $viewer)) {
75
70
throw new Exception(
76
71
pht(