@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Stop the debugging view for typeahead datasources from fataling
Summary: Fixes T13119. Ref T13120. This isn't the world's most elegant patch, but restores the debugging version of this view to service.
Test Plan: Viewed debugging phage (at `/typeahead/class/`). Used the actual proxy (by changing a datasource custom field from the comment area).
Maniphest Tasks: T13120, T13119
Differential Revision: https://secure.phabricator.com/D19304
+10
+10
src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
+10
src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
···
276
276
// format to make it easier to debug typeahead output.
277
277
278
278
foreach ($sources as $key => $source) {
279
+
// See T13119. Exclude proxy datasources from the dropdown since they
280
+
// fatal if built like this without actually being configured with an
281
+
// underlying datasource. This is a bit hacky but this is just a
282
+
// debugging/development UI anyway.
283
+
if ($source instanceof PhabricatorTypeaheadProxyDatasource) {
284
+
unset($sources[$key]);
285
+
continue;
286
+
}
287
+
279
288
// This can happen with composite or generic sources.
280
289
if (!$source->getDatasourceApplicationClass()) {
281
290
continue;
282
291
}
292
+
283
293
if (!PhabricatorApplication::isClassInstalledForViewer(
284
294
$source->getDatasourceApplicationClass(),
285
295
$viewer)) {