@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix some grammatical gender constants
Summary: Ref T5267. I missed these in the variable types conversion.
Test Plan: `arc unit --everything`
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T5267
Differential Revision: https://secure.phabricator.com/D16824
+4
-4
+4
-4
src/applications/settings/setting/PhabricatorPronounSetting.php
+4
-4
src/applications/settings/setting/PhabricatorPronounSetting.php
···
22
22
}
23
23
24
24
public function getSettingDefaultValue() {
25
-
return PhutilPerson::SEX_UNKNOWN;
25
+
return PhutilPerson::GENDER_UNKNOWN;
26
26
}
27
27
28
28
protected function getSelectOptions() {
···
37
37
$label_his = pht('%s updated his profile', $username);
38
38
39
39
return array(
40
-
PhutilPerson::SEX_UNKNOWN => $label_unknown,
41
-
PhutilPerson::SEX_MALE => $label_his,
42
-
PhutilPerson::SEX_FEMALE => $label_her,
40
+
PhutilPerson::GENDER_UNKNOWN => $label_unknown,
41
+
PhutilPerson::GENDER_MASCULINE => $label_his,
42
+
PhutilPerson::GENDER_FEMININE => $label_her,
43
43
);
44
44
}
45
45