@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Subversion: fix empty "Authored on" date on commit pages

Summary:
Subversion does not allow to have local commits. So, manage this case.

Closes T15612

Test Plan:
Surf a git commit: nothing changed.

Surf a svn commit: the "Authored on" date is not empty anymore.

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15612

Differential Revision: https://we.phorge.it/D25796

+7
+7
src/applications/diffusion/controller/DiffusionCommitController.php
··· 624 624 $author_view = $commit->newCommitAuthorView($viewer); 625 625 if ($author_view) { 626 626 $author_date = $data->getAuthorEpoch(); 627 + 628 + // Add support to Subversion commits that only have one date, 629 + // since in SVN you cannot prepare local commits to push them later. 630 + if ($author_date === null) { 631 + $author_date = $commit->getEpoch(); 632 + } 633 + 627 634 $author_date = phabricator_datetime($author_date, $viewer); 628 635 629 636 $provenance_list->addItem(