@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix PHP 8.1 strlen(NULL) errors running `bin/lock log`
Summary: Ref T15064
Test Plan:
- Run `bin/lock log --enable` and `bin/lock log --disable`
- Run `bin/lock log` with no args
See deprecation warnings without this patch for all three commands and no deprecation warnings with this patch
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15064
Differential Revision: https://we.phorge.it/D26601
+2
-2
+2
-2
src/applications/daemon/management/PhabricatorLockLogManagementWorkflow.php
+2
-2
src/applications/daemon/management/PhabricatorLockLogManagementWorkflow.php
···
38
38
$with_name = $args->getArg('name');
39
39
40
40
if ($is_enable || $is_disable) {
41
-
if (strlen($with_name)) {
41
+
if (phutil_nonempty_string($with_name)) {
42
42
throw new PhutilArgumentUsageException(
43
43
pht(
44
44
'You can not both "--enable" or "--disable" with search '.
···
99
99
$conn = $table->establishConnection('r');
100
100
101
101
$parts = array();
102
-
if (strlen($with_name)) {
102
+
if (phutil_nonempty_string($with_name)) {
103
103
$parts[] = qsprintf(
104
104
$conn,
105
105
'lockName = %s',