@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix "before/after" cursor paging for API call "feed.query"
Summary:
Ref T13266. See <https://discourse.phabricator-community.org/t/undefined-method-setafterid-when-calling-feed-query/2653>.
This older API call needs an update to the newer paging/cursor API.
Test Plan: Called `feed.query` with an "after" parameter.
Reviewers: amckinley
Reviewed By: amckinley
Subscribers: Itms
Maniphest Tasks: T13266
Differential Revision: https://secure.phabricator.com/D20456
+11
-9
+11
-9
src/applications/feed/conduit/FeedQueryConduitAPIMethod.php
+11
-9
src/applications/feed/conduit/FeedQueryConduitAPIMethod.php
···
63
63
$view_type = 'data';
64
64
}
65
65
66
-
$limit = $request->getValue('limit');
67
-
if (!$limit) {
68
-
$limit = $this->getDefaultLimit();
69
-
}
70
-
71
66
$query = id(new PhabricatorFeedQuery())
72
-
->setLimit($limit)
73
67
->setViewer($user);
74
68
75
69
$filter_phids = $request->getValue('filterPHIDs');
···
77
71
$query->withFilterPHIDs($filter_phids);
78
72
}
79
73
74
+
$limit = $request->getValue('limit');
75
+
if (!$limit) {
76
+
$limit = $this->getDefaultLimit();
77
+
}
78
+
79
+
$pager = id(new AphrontCursorPagerView())
80
+
->setPageSize($limit);
81
+
80
82
$after = $request->getValue('after');
81
83
if (strlen($after)) {
82
-
$query->setAfterID($after);
84
+
$pager->setAfterID($after);
83
85
}
84
86
85
87
$before = $request->getValue('before');
86
88
if (strlen($before)) {
87
-
$query->setBeforeID($before);
89
+
$pager->setBeforeID($before);
88
90
}
89
91
90
-
$stories = $query->execute();
92
+
$stories = $query->executeWithCursorPager($pager);
91
93
92
94
if ($stories) {
93
95
foreach ($stories as $story) {