@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove unused methods in PhabricatorEditorExtension
Summary:
The methods `newRequiredTransasctionError()` [sic!] and `newInvalidTransactionError()` are not called anywhere in the codebase. Both are `final protected`, thus remove them.
Incidentally, speedup Diviner generation by at least 0.000000000000000000000001 milliseconds.
Test Plan: Grep the code.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25643
-14
-14
src/applications/transactions/engineextension/PhabricatorEditorExtension.php
-14
src/applications/transactions/engineextension/PhabricatorEditorExtension.php
···
66
66
$xaction);
67
67
}
68
68
69
-
final protected function newRequiredTransasctionError(
70
-
PhabricatorApplicationTransaction $xaction,
71
-
$message) {
72
-
return $this->newError($xaction, pht('Required'), $message)
73
-
->setIsMissingFieldError(true);
74
-
}
75
-
76
-
final protected function newInvalidTransactionError(
77
-
PhabricatorApplicationTransaction $xaction,
78
-
$message) {
79
-
return $this->newTransactionError($xaction, pht('Invalid'), $message);
80
-
}
81
-
82
-
83
69
}