@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Drop the legacy hunk table
Summary: Ref T13054. Ref T8475. This table has had no readers or writers for more than a year after it was migrated to the modern table.
Test Plan: Ran migration, verified that all the data was still around.
Maniphest Tasks: T13054, T8475
Differential Revision: https://secure.phabricator.com/D19056
+1
-39
+1
resources/sql/autopatches/20180210.hunk.01.droplegacy.sql
+1
resources/sql/autopatches/20180210.hunk.01.droplegacy.sql
···
1
+
DROP TABLE {$NAMESPACE}_differential.differential_hunk;
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
481
481
'DifferentialInlineCommentQuery' => 'applications/differential/query/DifferentialInlineCommentQuery.php',
482
482
'DifferentialJIRAIssuesCommitMessageField' => 'applications/differential/field/DifferentialJIRAIssuesCommitMessageField.php',
483
483
'DifferentialJIRAIssuesField' => 'applications/differential/customfield/DifferentialJIRAIssuesField.php',
484
-
'DifferentialLegacyHunk' => 'applications/differential/storage/DifferentialLegacyHunk.php',
485
484
'DifferentialLegacyQuery' => 'applications/differential/constants/DifferentialLegacyQuery.php',
486
485
'DifferentialLineAdjustmentMap' => 'applications/differential/parser/DifferentialLineAdjustmentMap.php',
487
486
'DifferentialLintField' => 'applications/differential/customfield/DifferentialLintField.php',
···
5644
5643
'DifferentialInlineCommentQuery' => 'PhabricatorOffsetPagedQuery',
5645
5644
'DifferentialJIRAIssuesCommitMessageField' => 'DifferentialCommitMessageCustomField',
5646
5645
'DifferentialJIRAIssuesField' => 'DifferentialStoredCustomField',
5647
-
'DifferentialLegacyHunk' => 'DifferentialHunk',
5648
5646
'DifferentialLegacyQuery' => 'Phobject',
5649
5647
'DifferentialLineAdjustmentMap' => 'Phobject',
5650
5648
'DifferentialLintField' => 'DifferentialHarbormasterField',
-37
src/applications/differential/storage/DifferentialLegacyHunk.php
-37
src/applications/differential/storage/DifferentialLegacyHunk.php
···
1
-
<?php
2
-
3
-
final class DifferentialLegacyHunk extends DifferentialHunk {
4
-
5
-
protected $changes;
6
-
7
-
protected function getConfiguration() {
8
-
return array(
9
-
self::CONFIG_COLUMN_SCHEMA => array(
10
-
'changes' => 'text?',
11
-
'oldOffset' => 'uint32',
12
-
'oldLen' => 'uint32',
13
-
'newOffset' => 'uint32',
14
-
'newLen' => 'uint32',
15
-
),
16
-
self::CONFIG_KEY_SCHEMA => array(
17
-
'changesetID' => array(
18
-
'columns' => array('changesetID'),
19
-
),
20
-
),
21
-
) + parent::getConfiguration();
22
-
}
23
-
24
-
public function getTableName() {
25
-
return 'differential_hunk';
26
-
}
27
-
28
-
public function getDataEncoding() {
29
-
return 'utf8';
30
-
}
31
-
32
-
public function forceEncoding($encoding) {
33
-
// Not supported, these are always utf8.
34
-
return $this;
35
-
}
36
-
37
-
}