-9

src/applications/differential/phid/DifferentialRevisionPHIDType.php

reviewed

··· 44 44 if ($revision->isClosed()) { 45 45 $handle->setStatus(PhabricatorObjectHandle::STATUS_CLOSED); 46 46 } 47 47 - 48 48 - $icon = $revision->getStatusIcon(); 49 49 - $color = $revision->getStatusIconColor(); 50 50 - $name = $revision->getStatusDisplayName(); 51 51 - 52 52 - $handle 53 53 - ->setStateIcon($icon) 54 54 - ->setStateColor($color) 55 55 - ->setStateName($name); 56 47 } 57 48 } 58 49

+2 -4

src/applications/maniphest/controller/ManiphestTaskDetailController.php

reviewed

··· 413 413 414 414 foreach ($commit_phids as $phid) { 415 415 $revisions_commits[$phid] = $handles->renderHandle($phid) 416 416 - ->setShowHovercard(true) 417 417 - ->setShowStateIcon(true); 416 416 + ->setShowHovercard(true); 418 417 $revision_phid = key($drev_edges[$phid][$commit_drev]); 419 418 $revision_handle = $handles->getHandleIfExists($revision_phid); 420 419 if ($revision_handle) { ··· 435 434 436 435 $edge_handles = $viewer->loadHandles(array_keys($edges[$edge_type])); 437 436 438 438 - $edge_list = $edge_handles->renderList() 439 439 - ->setShowStateIcons(true); 437 437 + $edge_list = $edge_handles->renderList(); 440 438 441 439 $view->addProperty($edge_name, $edge_list); 442 440 }

-53

src/applications/phid/PhabricatorObjectHandle.php

reviewed

··· 33 33 private $commandLineObjectName; 34 34 private $mailStampName; 35 35 36 36 - private $stateIcon; 37 37 - private $stateColor; 38 38 - private $stateName; 39 39 - 40 36 public function setIcon($icon) { 41 37 $this->icon = $icon; 42 38 return $this; ··· 297 293 */ 298 294 public function isComplete() { 299 295 return $this->complete; 300 300 - } 301 301 - 302 302 - public function setStateIcon($state_icon) { 303 303 - $this->stateIcon = $state_icon; 304 304 - return $this; 305 305 - } 306 306 - 307 307 - public function getStateIcon() { 308 308 - return $this->stateIcon; 309 309 - } 310 310 - 311 311 - public function setStateColor($state_color) { 312 312 - $this->stateColor = $state_color; 313 313 - return $this; 314 314 - } 315 315 - 316 316 - public function getStateColor() { 317 317 - return $this->stateColor; 318 318 - } 319 319 - 320 320 - public function setStateName($state_name) { 321 321 - $this->stateName = $state_name; 322 322 - return $this; 323 323 - } 324 324 - 325 325 - public function getStateName() { 326 326 - return $this->stateName; 327 327 - } 328 328 - 329 329 - public function renderStateIcon() { 330 330 - $icon = $this->getStateIcon(); 331 331 - if ($icon === null) { 332 332 - $icon = 'fa-question-circle-o'; 333 333 - } 334 334 - 335 335 - $color = $this->getStateColor(); 336 336 - 337 337 - $name = $this->getStateName(); 338 338 - if ($name === null) { 339 339 - $name = pht('Unknown'); 340 340 - } 341 341 - 342 342 - return id(new PHUIIconView()) 343 343 - ->setIcon($icon, $color) 344 344 - ->addSigil('has-tooltip') 345 345 - ->setMetadata( 346 346 - array( 347 347 - 'tip' => $name, 348 348 - )); 349 296 } 350 297 351 298 public function renderLink($name = null) {

-15

src/applications/phid/view/PHUIHandleListView.php

reviewed

··· 13 13 private $handleList; 14 14 private $asInline; 15 15 private $asText; 16 16 - private $showStateIcons; 17 16 private $glyphLimit; 18 17 19 18 public function setHandleList(PhabricatorHandleList $list) { ··· 39 38 return $this->asText; 40 39 } 41 40 42 42 - public function setShowStateIcons($show_state_icons) { 43 43 - $this->showStateIcons = $show_state_icons; 44 44 - return $this; 45 45 - } 46 46 - 47 47 - public function getShowStateIcons() { 48 48 - return $this->showStateIcons; 49 49 - } 50 50 - 51 41 public function setGlyphLimit($glyph_limit) { 52 42 $this->glyphLimit = $glyph_limit; 53 43 return $this; ··· 70 60 protected function getTagContent() { 71 61 $list = $this->handleList; 72 62 73 73 - $show_state_icons = $this->getShowStateIcons(); 74 63 $glyph_limit = $this->getGlyphLimit(); 75 64 76 65 $items = array(); ··· 78 67 $view = $list->renderHandle($handle->getPHID()) 79 68 ->setShowHovercard(true) 80 69 ->setAsText($this->getAsText()); 81 81 - 82 82 - if ($show_state_icons) { 83 83 - $view->setShowStateIcon(true); 84 84 - } 85 70 86 71 if ($glyph_limit) { 87 72 $view->setGlyphLimit($glyph_limit);

-15

src/applications/phid/view/PHUIHandleView.php

reviewed

··· 17 17 private $asText; 18 18 private $useShortName; 19 19 private $showHovercard; 20 20 - private $showStateIcon; 21 20 private $glyphLimit; 22 21 23 22 public function setHandleList(PhabricatorHandleList $list) { ··· 48 47 public function setShowHovercard($hovercard) { 49 48 $this->showHovercard = $hovercard; 50 49 return $this; 51 51 - } 52 52 - 53 53 - public function setShowStateIcon($show_state_icon) { 54 54 - $this->showStateIcon = $show_state_icon; 55 55 - return $this; 56 56 - } 57 57 - 58 58 - public function getShowStateIcon() { 59 59 - return $this->showStateIcon; 60 50 } 61 51 62 52 public function setGlyphLimit($glyph_limit) { ··· 102 92 $link = $handle->renderHovercardLink($name); 103 93 } else { 104 94 $link = $handle->renderLink($name); 105 105 - } 106 106 - 107 107 - if ($this->showStateIcon) { 108 108 - $icon = $handle->renderStateIcon(); 109 109 - $link = array($icon, ' ', $link); 110 95 } 111 96 112 97 return $link;

-10

src/applications/repository/phid/PhabricatorRepositoryCommitPHIDType.php

reviewed

··· 81 81 $handle->setFullName($full_name); 82 82 $handle->setURI($commit->getURI()); 83 83 $handle->setTimestamp($commit->getEpoch()); 84 84 - 85 85 - $status = $commit->getAuditStatusObject(); 86 86 - $icon = $status->getIcon(); 87 87 - $color = $status->getColor(); 88 88 - $name = $status->getName(); 89 89 - 90 90 - $handle 91 91 - ->setStateIcon($icon) 92 92 - ->setStateColor($color) 93 93 - ->setStateName($name); 94 84 } 95 85 } 96 86