@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Display #1 instead of #comment-1 in comment anchors
Summary: I changed this a long time ago probably without knowing that this format is usable in Remarkup.
Test Plan: Viewed revision and task.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4413
+7
-4
+4
-3
src/applications/differential/view/DifferentialRevisionCommentView.php
+4
-3
src/applications/differential/view/DifferentialRevisionCommentView.php
···
180
180
} else {
181
181
$xaction_view->setEpoch($comment->getDateCreated());
182
182
if ($this->anchorName) {
183
-
$anchor_name = $this->anchorName;
184
-
$anchor_text = 'D'.$comment->getRevisionID().'#'.$anchor_name;
183
+
$anchor_text =
184
+
'D'.$comment->getRevisionID().
185
+
'#'.preg_replace('/^comment-/', '', $this->anchorName);
185
186
186
-
$xaction_view->setAnchor($anchor_name, $anchor_text);
187
+
$xaction_view->setAnchor($this->anchorName, $anchor_text);
187
188
}
188
189
}
189
190
+3
-1
src/applications/maniphest/view/ManiphestTransactionDetailView.php
+3
-1
src/applications/maniphest/view/ManiphestTransactionDetailView.php
···
206
206
$xaction_view->setEpoch($any_transaction->getDateCreated());
207
207
if ($this->commentNumber) {
208
208
$anchor_name = 'comment-'.$this->commentNumber;
209
-
$anchor_text = 'T'.$any_transaction->getTaskID().'#'.$anchor_name;
209
+
$anchor_text =
210
+
'T'.$any_transaction->getTaskID().
211
+
'#'.$this->commentNumber;
210
212
211
213
$xaction_view->setAnchor($anchor_name, $anchor_text);
212
214
}