@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clarify the behavior of "audit.can-author-close-audit"
Summary:
Ref T13631. This option has a behavior other than the behavior implied by the name and documented.
Document the correct behavior, at least. This can likely be removed after T10574.
Test Plan: Read config option help in Config.
Maniphest Tasks: T13631
Differential Revision: https://secure.phabricator.com/D21610
+9
-3
+9
-3
src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php
+9
-3
src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php
···
61
61
->setDescription(pht('Hard byte limit on including patches in email.')),
62
62
$this->newOption('metamta.diffusion.time-limit', 'int', 60)
63
63
->setDescription(pht('Hard time limit on generating patches.')),
64
+
64
65
$this->newOption(
65
66
'audit.can-author-close-audit',
66
67
'bool',
67
68
false)
68
69
->setBoolOptions(
69
70
array(
70
-
pht('Enable Closing Audits'),
71
-
pht('Disable Closing Audits'),
71
+
pht('Enable Self-Accept'),
72
+
pht('Disable Self-Accept'),
72
73
))
73
-
->setDescription(pht('Controls whether Author can Close Audits.')),
74
+
->setDescription(
75
+
pht(
76
+
'Allows the author of a commit to be an auditor and accept their '.
77
+
'own commits. Note that this behavior is different from the '.
78
+
'behavior implied by the name of the option: long ago, it did '.
79
+
'something else.')),
74
80
75
81
$this->newOption('bugtraq.url', 'string', null)
76
82
->addExample('https://bugs.php.net/%BUGID%', pht('PHP bugs'))