@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix "Send an email to" Herald rule for Differential
Summary: Herald returns a map of `phid => true`. This is unintuitive and should probably be cleaned up eventually.
Test Plan: With a "Send an email to" rule, updated a revision and saw no error in error log.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: aran, epriestley
Differential Revision: https://secure.phabricator.com/D8527
+2
-1
+2
-1
src/applications/differential/editor/DifferentialTransactionEditor.php
+2
-1
src/applications/differential/editor/DifferentialTransactionEditor.php
···
1428
1428
}
1429
1429
1430
1430
// Save extra email PHIDs for later.
1431
-
$this->heraldEmailPHIDs = $adapter->getEmailPHIDsAddedByHerald();
1431
+
$email_phids = $adapter->getEmailPHIDsAddedByHerald();
1432
+
$this->heraldEmailPHIDs = array_keys($email_phids);
1432
1433
1433
1434
// Apply build plans.
1434
1435
HarbormasterBuildable::applyBuildPlans(