@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove ManiphestAuxiliaryFieldSpecification

Summary: Ref T2217. This legacy writer is no longer called.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2217

Differential Revision: https://secure.phabricator.com/D7112

-57
-1
src/__phutil_library_map__.php
··· 690 690 'LiskMigrationIterator' => 'infrastructure/storage/lisk/LiskMigrationIterator.php', 691 691 'LiskRawMigrationIterator' => 'infrastructure/storage/lisk/LiskRawMigrationIterator.php', 692 692 'ManiphestAction' => 'applications/maniphest/constants/ManiphestAction.php', 693 - 'ManiphestAuxiliaryFieldSpecification' => 'applications/maniphest/auxiliaryfield/ManiphestAuxiliaryFieldSpecification.php', 694 693 'ManiphestBatchEditController' => 'applications/maniphest/controller/ManiphestBatchEditController.php', 695 694 'ManiphestConfiguredCustomField' => 'applications/maniphest/field/ManiphestConfiguredCustomField.php', 696 695 'ManiphestConstants' => 'applications/maniphest/constants/ManiphestConstants.php',
-56
src/applications/maniphest/auxiliaryfield/ManiphestAuxiliaryFieldSpecification.php
··· 1 - <?php 2 - 3 - /** 4 - * TODO: Destroy after ApplicationTransactions. 5 - */ 6 - final class ManiphestAuxiliaryFieldSpecification { 7 - 8 - public static function writeLegacyAuxiliaryUpdates( 9 - ManiphestTask $task, 10 - array $map) { 11 - 12 - $table = new ManiphestCustomFieldStorage(); 13 - $conn_w = $table->establishConnection('w'); 14 - $update = array(); 15 - $remove = array(); 16 - 17 - foreach ($map as $key => $value) { 18 - $index = PhabricatorHash::digestForIndex($key); 19 - if ($value === null) { 20 - $remove[$index] = true; 21 - } else { 22 - $update[$index] = $value; 23 - } 24 - } 25 - 26 - if ($remove) { 27 - queryfx( 28 - $conn_w, 29 - 'DELETE FROM %T WHERE objectPHID = %s AND fieldIndex IN (%Ls)', 30 - $table->getTableName(), 31 - $task->getPHID(), 32 - array_keys($remove)); 33 - } 34 - 35 - if ($update) { 36 - $sql = array(); 37 - foreach ($update as $index => $val) { 38 - $sql[] = qsprintf( 39 - $conn_w, 40 - '(%s, %s, %s)', 41 - $task->getPHID(), 42 - $index, 43 - $val); 44 - } 45 - queryfx( 46 - $conn_w, 47 - 'INSERT INTO %T (objectPHID, fieldIndex, fieldValue) 48 - VALUES %Q ON DUPLICATE KEY 49 - UPDATE fieldValue = VALUES(fieldValue)', 50 - $table->getTableName(), 51 - implode(', ', $sql)); 52 - } 53 - 54 - } 55 - 56 - }