@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Maybe fix excluding to / cc folks on differential emails
Summary: Ref T5185. By code inspection, I am pretty sure before this patch it was doing a set of a get on itself which does nothing. Now, being careful not to break Facebook we get the proper exclusion phids. I am pretty sure the folks in T5185 are experiencing this in Differential only.
Test Plan: Get some folks on T5185 to play with this
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T5185
Differential Revision: https://secure.phabricator.com/D10087
+10
-4
+10
-4
src/applications/differential/mail/DifferentialReplyHandler.php
+10
-4
src/applications/differential/mail/DifferentialReplyHandler.php
···
146
146
->setContent($body));
147
147
}
148
148
149
+
// NOTE: We have to be careful about this because Facebook's
150
+
// implementation jumps straight into handleAction() and will not have
151
+
// a PhabricatorMetaMTAReceivedMail object.
152
+
if ($this->receivedMail) {
153
+
$exclude = $this->receivedMail->getExcludeMailRecipientPHIDs();
154
+
} else {
155
+
$exclude = $this->getExcludeMailRecipientPHIDs();
156
+
}
157
+
149
158
$editor = id(new DifferentialTransactionEditor())
150
159
->setActor($actor)
151
-
->setExcludeMailRecipientPHIDs($this->getExcludeMailRecipientPHIDs())
160
+
->setExcludeMailRecipientPHIDs($exclude)
152
161
->setContinueOnMissingFields(true)
153
162
->setContinueOnNoEffect(true);
154
163
155
-
// NOTE: We have to be careful about this because Facebook's
156
-
// implementation jumps straight into handleAction() and will not have
157
-
// a PhabricatorMetaMTAReceivedMail object.
158
164
if ($this->receivedMail) {
159
165
$content_source = PhabricatorContentSource::newForSource(
160
166
PhabricatorContentSource::SOURCE_EMAIL,