recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add role=dialog to all dialogs

Summary: Seen some complaints about usability here, adding role=dialog to improve when these trigger.

Test Plan: Turn on Voiceover, tab over to log out link, here proper dialog title and text before highlighted submit button.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15993

Chad Little b23c85b1 e64dfbcb

+1
+1
src/view/AphrontDialogView.php
··· 276 276 $attributes = array( 277 277 'class' => implode(' ', $classes), 278 278 'sigil' => 'jx-dialog', 279 + 'role' => 'dialog', 279 280 ); 280 281 281 282 $form_attributes = array(