@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
[Redesign] Add back Advanced Search
Summary: Ref T8099, I failed to test "Advanced Search" which disappeared during the last commit.
Test Plan: Test built-in, saved, and advanced search filters.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D13035
+19
-20
+19
-20
src/applications/search/controller/PhabricatorApplicationSearchController.php
+19
-20
src/applications/search/controller/PhabricatorApplicationSearchController.php
···
185
185
$title = pht('Advanced Search');
186
186
}
187
187
188
+
$box = id(new PHUIObjectBoxView())
189
+
->setHeaderText($title);
190
+
191
+
if ($run_query || $named_query) {
192
+
$box->setShowHide(
193
+
pht('Edit Query'),
194
+
pht('Hide Query'),
195
+
$form,
196
+
$this->getApplicationURI('query/advanced/?query='.$query_key));
197
+
} else {
198
+
$box->setForm($form);
199
+
}
200
+
201
+
$nav->appendChild($box);
202
+
188
203
if ($run_query) {
189
-
$anchor = id(new PhabricatorAnchorView())
190
-
->setAnchorName('R');
204
+
$box->setAnchor(
205
+
id(new PhabricatorAnchorView())
206
+
->setAnchorName('R'));
191
207
192
208
try {
193
209
$query = $engine->buildQueryFromSavedQuery($saved_query);
···
211
227
$saved_query);
212
228
}
213
229
214
-
$box = id(new PHUIObjectBoxView())
215
-
->setHeaderText($title)
216
-
->setAnchor($anchor);
217
-
218
-
$box->setShowHide(
219
-
pht('Edit Query'),
220
-
pht('Hide Query'),
221
-
$form,
222
-
$this->getApplicationURI('query/advanced/?query='.$query_key));
223
-
224
230
if ($list instanceof AphrontTableView) {
225
231
$box->setTable($list);
226
232
} else {
227
233
$box->setObjectList($list);
228
234
}
229
-
$nav->appendChild($box);
230
235
231
236
// TODO: This is a bit hacky.
232
237
if ($list instanceof PHUIObjectItemListView) {
···
249
254
}
250
255
251
256
if ($errors) {
252
-
$errors = id(new PHUIInfoView())
253
-
->setTitle(pht('Query Errors'))
254
-
->setErrors($errors);
255
-
}
256
-
257
-
if ($errors) {
258
-
$nav->appendChild($errors);
257
+
$box->setFormErrors($errors, pht('Query Errors'));
259
258
}
260
259
261
260
$crumbs = $parent