recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4

Summary: Backport upstream's https://github.com/php-mime-mail-parser/php-mime-mail-parser/commit/39633e054b4b3290775c5e9b43d3bb8f47128433 for PHP 8.4 compatibility.

Test Plan: Run static code analysis.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25840

Andre Klapper b2536759 6ec5c88b

+2 -2
+1 -1
externals/mimemailparser/MiddlewareStack.php
··· 29 29 * 30 30 * @param Middleware $middleware 31 31 */ 32 - public function __construct(MiddleWareContracts $middleware = null) 32 + public function __construct(?MiddleWareContracts $middleware = null) 33 33 { 34 34 $this->middleware = $middleware; 35 35 }
+1 -1
externals/mimemailparser/Parser.php
··· 74 74 * 75 75 * @param CharsetManager|null $charset 76 76 */ 77 - public function __construct(CharsetManager $charset = null) 77 + public function __construct(?CharsetManager $charset = null) 78 78 { 79 79 if ($charset == null) { 80 80 $charset = new Charset();