@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Decouple date and time input classes on AphrontFormDateControl's so that disabling time doesn't disable date.
Summary: Fixes T8319, Decouple date and time input classes on AphrontFormDateControl's so that disabling time doesn't disable date.
Test Plan: Create new event, make it all day, time input should be hidden, but not date input.
Reviewers: chad, #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8319
Differential Revision: https://secure.phabricator.com/D13021
+22
-20
+12
-12
resources/celerity/map.php
+12
-12
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '439658b5',
10
+
'core.pkg.css' => '4e7df908',
11
11
'core.pkg.js' => '328799d0',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => 'bb338e4b',
···
134
134
'rsrc/css/phui/phui-document.css' => '94d5dcd8',
135
135
'rsrc/css/phui/phui-feed-story.css' => 'c9f3a0b5',
136
136
'rsrc/css/phui/phui-fontkit.css' => 'dd8ddf27',
137
-
'rsrc/css/phui/phui-form-view.css' => '79793450',
137
+
'rsrc/css/phui/phui-form-view.css' => '808329f2',
138
138
'rsrc/css/phui/phui-form.css' => 'f535f938',
139
139
'rsrc/css/phui/phui-header-view.css' => '75aaf372',
140
140
'rsrc/css/phui/phui-icon.css' => 'bc766998',
···
443
443
'rsrc/js/core/behavior-device.js' => 'a205cf28',
444
444
'rsrc/js/core/behavior-drag-and-drop-textarea.js' => '6d49590e',
445
445
'rsrc/js/core/behavior-error-log.js' => '6882e80a',
446
-
'rsrc/js/core/behavior-fancy-datepicker.js' => '5c0f680f',
446
+
'rsrc/js/core/behavior-fancy-datepicker.js' => '510b5809',
447
447
'rsrc/js/core/behavior-file-tree.js' => '88236f00',
448
448
'rsrc/js/core/behavior-form.js' => '5c54cbf3',
449
449
'rsrc/js/core/behavior-gesture.js' => '3ab51e2c',
···
576
576
'javelin-behavior-durable-column' => '16c695bf',
577
577
'javelin-behavior-error-log' => '6882e80a',
578
578
'javelin-behavior-event-all-day' => '38dcf3c8',
579
-
'javelin-behavior-fancy-datepicker' => '5c0f680f',
579
+
'javelin-behavior-fancy-datepicker' => '510b5809',
580
580
'javelin-behavior-global-drag-and-drop' => 'c8e57404',
581
581
'javelin-behavior-herald-rule-editor' => '7ebaeed3',
582
582
'javelin-behavior-high-security-warning' => 'a464fe03',
···
776
776
'phui-font-icon-base-css' => '3dad2ae3',
777
777
'phui-fontkit-css' => 'dd8ddf27',
778
778
'phui-form-css' => 'f535f938',
779
-
'phui-form-view-css' => '79793450',
779
+
'phui-form-view-css' => '808329f2',
780
780
'phui-header-view-css' => '75aaf372',
781
781
'phui-icon-view-css' => 'bc766998',
782
782
'phui-image-mask-css' => '5a8b09c8',
···
1167
1167
'javelin-typeahead-source',
1168
1168
'javelin-util',
1169
1169
),
1170
+
'510b5809' => array(
1171
+
'javelin-behavior',
1172
+
'javelin-util',
1173
+
'javelin-dom',
1174
+
'javelin-stratcom',
1175
+
'javelin-vector',
1176
+
),
1170
1177
'519705ea' => array(
1171
1178
'javelin-install',
1172
1179
'javelin-dom',
···
1233
1240
'javelin-mask',
1234
1241
'javelin-uri',
1235
1242
'javelin-routable',
1236
-
),
1237
-
'5c0f680f' => array(
1238
-
'javelin-behavior',
1239
-
'javelin-util',
1240
-
'javelin-dom',
1241
-
'javelin-stratcom',
1242
-
'javelin-vector',
1243
1243
),
1244
1244
'5c54cbf3' => array(
1245
1245
'javelin-behavior',
+4
-4
src/view/form/control/AphrontFormDateControl.php
+4
-4
src/view/form/control/AphrontFormDateControl.php
···
184
184
'sigil' => 'date-input',
185
185
'value' => $this->getDateInputValue(),
186
186
'type' => 'text',
187
-
'class' => 'aphront-form-date-time-input',
187
+
'class' => 'aphront-form-date-input',
188
188
),
189
189
'');
190
190
191
191
$date_div = javelin_tag(
192
192
'div',
193
193
array(
194
-
'class' => 'aphront-form-date-time-input-container',
194
+
'class' => 'aphront-form-date-input-container',
195
195
),
196
196
$date_sel);
197
197
···
225
225
'sigil' => 'time-input',
226
226
'value' => $this->getTimeInputValue(),
227
227
'type' => 'text',
228
-
'class' => 'aphront-form-date-time-input',
228
+
'class' => 'aphront-form-time-input',
229
229
),
230
230
'');
231
231
···
233
233
'div',
234
234
array(
235
235
'id' => $time_id,
236
-
'class' => 'aphront-form-date-time-input-container',
236
+
'class' => 'aphront-form-time-input-container',
237
237
),
238
238
$time_sel);
239
239
+6
-4
webroot/rsrc/css/phui/phui-form-view.css
+6
-4
webroot/rsrc/css/phui/phui-form-view.css
···
334
334
font-size: 16px;
335
335
}
336
336
337
-
.aphront-form-date-container .aphront-form-date-time-input-container {
337
+
.aphront-form-date-container .aphront-form-time-input-container,
338
+
.aphront-form-date-container .aphront-form-date-input-container {
338
339
position: relative;
339
340
display: inline-block;
340
341
width: 7em;
341
342
}
342
343
343
-
.aphront-form-date-container input.aphront-form-date-time-input {
344
+
.aphront-form-date-container input.aphront-form-time-input,
345
+
.aphront-form-date-container input.aphront-form-date-input {
344
346
width: 7em;
345
347
}
346
348
347
-
.aphront-form-date-time-input-container div.jx-typeahead-results a.jx-result {
349
+
.aphront-form-time-input-container div.jx-typeahead-results a.jx-result {
348
350
border: none;
349
351
}
350
352
···
470
472
opacity: 0.5;
471
473
}
472
474
473
-
.aphront-form-date-container.no-time .aphront-form-date-time-input{
475
+
.aphront-form-date-container.no-time .aphront-form-time-input{
474
476
display: none;
475
477
}
476
478