@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up two straggling UI issues in Phortune
Ref T13401. The checkout UI didn't get fully updated to the new View objects,
and account handles are still manually building a URI that goes to the wrong
place.
+6
-11
+3
-7
src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php
+3
-7
src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php
···
101
101
}
102
102
}
103
103
104
-
$cart_table = $this->buildCartContentTable($cart);
105
-
106
-
$cart_box = id(new PHUIObjectBoxView())
107
-
->setFormErrors($errors)
108
-
->setHeaderText(pht('Cart Contents'))
109
-
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
110
-
->setTable($cart_table);
104
+
$cart_box = id(new PhortuneOrderItemsView())
105
+
->setViewer($viewer)
106
+
->setOrder($cart);
111
107
112
108
$title = $cart->getName();
113
109
+3
-4
src/applications/phortune/phid/PhortuneAccountPHIDType.php
+3
-4
src/applications/phortune/phid/PhortuneAccountPHIDType.php
···
32
32
foreach ($handles as $phid => $handle) {
33
33
$account = $objects[$phid];
34
34
35
-
$id = $account->getID();
36
-
37
-
$handle->setName($account->getName());
38
-
$handle->setURI("/phortune/{$id}/");
35
+
$handle
36
+
->setName($account->getName())
37
+
->setURI($account->getURI());
39
38
}
40
39
}
41
40